jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Updated: (JCR-482) DocViewSaxEventGenerator may generate non-NS-wellformed XML
Date Wed, 19 Jul 2006 13:39:16 GMT
     [ http://issues.apache.org/jira/browse/JCR-482?page=all ]

Jukka Zitting updated JCR-482:
------------------------------

        Fix Version/s: 1.1
    Affects Version/s: 0.9
                       1.0
                       1.0.1
                           (was: 1.1)

Good point.

The spec requires the "relevant mappings" to be included in the "top-most XML element", but
in this case (concurrent introduction of new namespaces) I think it's better to include extra
namespaces as local xmlns settings than to skip the elements or to use unknown prefixes.

I see two ways to fix this. One is the straightforward solution you mentioned of adding missing
namespace mappings on the fly, and the other would be to block all changes to the namespace
registry while an XML export is in progress.

> Should there be consensus for that change I'm happy to give it a try

Please do, patches are very much welcome! :-)

> DocViewSaxEventGenerator may generate non-NS-wellformed XML
> -----------------------------------------------------------
>
>                 Key: JCR-482
>                 URL: http://issues.apache.org/jira/browse/JCR-482
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: xml
>    Affects Versions: 1.0, 1.0.1, 0.9
>         Environment: n/a
>            Reporter: Julian Reschke
>            Priority: Minor
>             Fix For: 1.1
>
>
> The XML serialization code relies on the fact that all required prefix-to-uri mappings
are known beforehand (actually, when serializing the root node). So there's an assumption
that the permanent namespace registry will never change during serialization, which may be
incorrect when another client adds namespace registrations while the XML export is in progress.
> To fix this, "addNamespacePrefixes" should ensure that namespace declarations have been
written for all prefixes used on the current node (node name + properties), potentially going
back to the namespace resolver when needed.
> (Should there be consensus for that change I'm happy to give it a try)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message