jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Guggisberg (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-476) Remove recently added getJCRPath()/getQPath() from NamespaceResolver
Date Wed, 19 Jul 2006 14:04:16 GMT
    [ http://issues.apache.org/jira/browse/JCR-476?page=comments#action_12422136 ] 
            
Stefan Guggisberg commented on JCR-476:
---------------------------------------

there are some minor javadoc issues with the QNameCache class  which could be easily fixed

once the patch has been committed.
since QNameCache caches both QNames and String representations i'd suggest to rename it 
to NameCache. 

apart from this +1 for the suggested changes

> Remove recently added getJCRPath()/getQPath() from NamespaceResolver
> --------------------------------------------------------------------
>
>                 Key: JCR-476
>                 URL: http://issues.apache.org/jira/browse/JCR-476
>             Project: Jackrabbit
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Tobias Bocanegra
>         Assigned To: Tobias Bocanegra
>            Priority: Minor
>         Attachments: jackrabbit.422765.patch
>
>
> issue JCR-473 added 2 new methods to NamespaceResolver: 
>     public Path getQPath(String jcrPath) throws MalformedPathException;
>     public String getJCRPath(Path qPath) throws NoPrefixDeclaredException;
> which do not belong here, since the NamespaceResolver has nothing to do with paths. suggest
to remove them.
> further is the naming of the QName related methods a bit vague. suggest to rename them
to:
>    QName parseName(String jcrName)
>    String formatName(QName qName)
> (although they do not belong here either, but helps to leverage evt. caching namespace
resolvers).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message