Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Received-SPF: pass (asf.osuosl.org: domain of stefan.guggisberg@gmail.com
 designates 64.233.162.205 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=YZBjOE3d8KP1erfJI3ai1B7V5/Uxjg29V3zDG+fPomzkHn9YmZfqvlNlM/dJ/+FI/puu/idfmIs/qTX0R8cMa+ZWKgr2Qqjvzug7yOdOW8ZmQD6jLRzZsGlxRnSdfmnmW/k3B3PFZy2cJQBlkpyHLfR1sWmZtRQhOXGzSeVbDdM=
Message-ID: <90a8d1c00606260123p442e7a02pabee636532257b4d@mail.gmail.com>
Date: Mon, 26 Jun 2006 10:23:29 +0200
From: "Stefan Guggisberg" <stefan.guggisberg@gmail.com>
To: dev@jackrabbit.apache.org
Subject: Re: Main Entry Point for Backup Tool
In-Reply-To: <fcbb46050606251334g5a8a62bew7e18861585a3770d@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <fcbb46050606251334g5a8a62bew7e18861585a3770d@mail.gmail.com>

hi nicolas,

i share tobi's concern regarding the naming of the methods.
save and restore are used in other contexts and may cause
confusion.

some comments regarding the proposed signatures:
- i suggest both methods throw IOException and RepositoryException.
  there's no need for specific SavingException and RestoreException
  as the context is already clear.
- if the methods are goping to be on Repository we'll also need some
  sort of authentication/authorization. a Credentials parameter would
  IMO be fine. both methods should also throw AccessDeniedExcpetion.

cheers
stefan

On 6/25/06, Nicolas Toper <ntoper@gmail.com> wrote:
> Hi,
>
> I am updating the RepositoryImpl class. Here is what it looks like (below).
>
> We have agreed on using In/OutputStream. However, now that I have advanced a
> little bit in the code, it raises a problem: I cannot use nio and since it
> is huge dataset, I would prefer to use it for performance issue. What do you
> think?
>
> Nicolas
> my blog! http://www.deviant-abstraction.net !!
>     /**
>      *
>      * This method restores data from an InputStream.
>      *
>      * @param InputStream savedData: InputStream containing the backup (and
> its parameters).
>      * @param File workingFolder: the folder used to unzip all data.
>      *
>      * @throws RestoreException. Generic exception during restore operation.
>      *
>      * @author: Nicolas Toper <ntoper@gmail.com>
>      *
>      */
>     public void restore(InputStream savedData, File workingFolder) throws
> RestoreException {
>
>         BackupRepository saveRepo = new BackupRepository(this, savedData,
> workingFolder);
>         saveRepo.restore();
>     }
>
>
>     /**
>      *
>      * This method saves from this repository to an OutputStream.
>      *
>      * @param outputStream out: Outputstream where the backup should be.
>      * @param BackupConfig conf: BackupConfig object containing all the
> parameters.
>      *
>      * @throws SavingException. Generic exception during saving operation.
>      *
>      * @author: Nicolas Toper <ntoper@gmail.com>
>      *
>      */
>     public void save(OutputStream out, BackupConfig conf) throws
> SavingException{
>
>         conf.init(this);
>         BackupRepository saveRepo = (BackupRepository) conf.getBackup();
>         saveRepo.save(out, conf);
>     }
>
>