jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Guggisberg" <stefan.guggisb...@gmail.com>
Subject Re: Main Entry Point for Backup Tool
Date Mon, 26 Jun 2006 09:30:35 GMT
On 6/26/06, Nicolas Toper <ntoper@gmail.com> wrote:
> Hi,
>
> About the names of the methods, which ones would you propose?

off the top of my head, how about:

backupRepository
restoreRepository

cheers
stefan

>
> About the exceptions: some other exceptions can be raised and they will all
> be propagated to this method. I need some specific exception to encapsulate
> them all, unless of course, you fill it is better to let them as they are?
>
> The user/password are in the BackupConfig class already. OK on the thrown
> exception.
>
>
> On 6/26/06, Stefan Guggisberg <stefan.guggisberg@gmail.com> wrote:
> >
> > hi nicolas,
> >
> > i share tobi's concern regarding the naming of the methods.
> > save and restore are used in other contexts and may cause
> > confusion.
> >
> > some comments regarding the proposed signatures:
> > - i suggest both methods throw IOException and RepositoryException.
> >   there's no need for specific SavingException and RestoreException
> >   as the context is already clear.
> > - if the methods are goping to be on Repository we'll also need some
> >   sort of authentication/authorization. a Credentials parameter would
> >   IMO be fine. both methods should also throw AccessDeniedExcpetion.
> >
> > cheers
> > stefan
> >
> > On 6/25/06, Nicolas Toper <ntoper@gmail.com> wrote:
> > > Hi,
> > >
> > > I am updating the RepositoryImpl class. Here is what it looks like
> > (below).
> > >
> > > We have agreed on using In/OutputStream. However, now that I have
> > advanced a
> > > little bit in the code, it raises a problem: I cannot use nio and since
> > it
> > > is huge dataset, I would prefer to use it for performance issue. What do
> > you
> > > think?
> > >
> > > Nicolas
> > > my blog! http://www.deviant-abstraction.net !!
> > >     /**
> > >      *
> > >      * This method restores data from an InputStream.
> > >      *
> > >      * @param InputStream savedData: InputStream containing the backup
> > (and
> > > its parameters).
> > >      * @param File workingFolder: the folder used to unzip all data.
> > >      *
> > >      * @throws RestoreException. Generic exception during restore
> > operation.
> > >      *
> > >      * @author: Nicolas Toper <ntoper@gmail.com>
> > >      *
> > >      */
> > >     public void restore(InputStream savedData, File workingFolder)
> > throws
> > > RestoreException {
> > >
> > >         BackupRepository saveRepo = new BackupRepository(this,
> > savedData,
> > > workingFolder);
> > >         saveRepo.restore();
> > >     }
> > >
> > >
> > >     /**
> > >      *
> > >      * This method saves from this repository to an OutputStream.
> > >      *
> > >      * @param outputStream out: Outputstream where the backup should be.
> > >      * @param BackupConfig conf: BackupConfig object containing all the
> > > parameters.
> > >      *
> > >      * @throws SavingException. Generic exception during saving
> > operation.
> > >      *
> > >      * @author: Nicolas Toper <ntoper@gmail.com>
> > >      *
> > >      */
> > >     public void save(OutputStream out, BackupConfig conf) throws
> > > SavingException{
> > >
> > >         conf.init(this);
> > >         BackupRepository saveRepo = (BackupRepository) conf.getBackup();
> > >         saveRepo.save(out, conf);
> > >     }
> > >
> > >
> >
>
>
>
> --
> a+
> Nico
> my blog! http://www.deviant-abstraction.net !!
>
>

Mime
View raw message