jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (JCR-405) PROPPATCH doesn't respect document order
Date Fri, 28 Apr 2006 10:07:37 GMT
     [ http://issues.apache.org/jira/browse/JCR-405?page=all ]
     
angela resolved JCR-405:
------------------------

    Fix Version: 1.0.1
     Resolution: Fixed

Committed revision: 397835  

The following modifications were made to the original patch:

- with jcr package two implementations were missing -> added changed impl for alterProperties
   and moved the handling of the old-alterProperties method to AbstractResource.

- calling the list entries 'item' shadowed an instance field in the 'jcr' package.
  since 'item' could be misleading due to the fact the jsr170 defines Items, i renamed the
variables.

- removed comment on outdated todo (and todo ;)

otherwise it was fine (although removal of extra catch for exception not related to property
modification e.g. lock was not part of this issue :)). thanks for the careful work.

regards
angela


> PROPPATCH doesn't respect document order
> ----------------------------------------
>
>          Key: JCR-405
>          URL: http://issues.apache.org/jira/browse/JCR-405
>      Project: Jackrabbit
>         Type: Bug

>   Components: webdav
>     Reporter: Julian Reschke
>     Assignee: angela
>     Priority: Minor
>      Fix For: 1.0.1
>  Attachments: diffs.txt
>
> PROPPATCH is currently implemented in terms of DavResource.alterProperties(...), which
takes a set of properties to be set and a set of properties to be removed. This is not sufficient
to model WebDAV's method semantics, as the order in which set/remove instructions appear is
supposed to be relevant.
> I have submitted a patch to the Litmus mailing list checking this (see <http://mailman.webdav.org/pipermail/litmus/2006-April/000196.html>).
> In jcr-server, alterProperties probably should be changed to take an (ordered) list of
set/remove instructions instead. The simplest approach for that would probably be to use a
List containing either DavProperty (set) or DavPropertyName (remove) objects.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message