jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-407) read IOHandlers from the config.xml
Date Thu, 20 Apr 2006 12:12:06 GMT
    [ http://issues.apache.org/jira/browse/JCR-407?page=comments#action_12375344 ] 

angela commented on JCR-407:

just a couple of comments regarding the patch.
first of all i would rather want the config to rely on interfaces as much as possible instead
of making the example implementations with the server/io package to a quasi standard. second
i think it would be better to create a basic (and very simple) IOManager implementation that
does not load any handlers.

this would lead to the following major changes of the patch:


- extend the IOHandler interface by a 'setIOManager(IOManager) method.
- create a IOManager implementation that does not init any handler. instead the internal list
is populated
  by calling 'addIOHandler).
- this would make the protected constructor of the DefaultIOManager redandant and the
  DefaultIOManager could do one thing as its name insinuates: provide some default behaviour
  handling import/export.
- the (optional) iomanager field with in the IOHandler can be set while adding the handler
  the managers list by calling IOHandler.setIOManager(this).
- the existing iohandler implementations need a default constructor


- The 'iohandler' elements should rather be children of the iomanager. they don't have a meaning
  but within the manager they belong to.
- 'iohandler' elements are optional
- 'iohandler' as well as 'iomanager' must define a class name pointing to an implementation
   the corresponding interfaces.
- the configuration expects but a empty constructor for both iohandler and iomanager

if nobody objects i would modify the config and iohandler/manager accordingly.

> read IOHandlers from the config.xml
> -----------------------------------
>          Key: JCR-407
>          URL: http://issues.apache.org/jira/browse/JCR-407
>      Project: Jackrabbit
>         Type: Improvement

>   Components: webdav
>     Versions: 1.0
>     Reporter: jeremi Joslin
>     Assignee: angela
>     Priority: Minor
>  Attachments: patchIOHandlers.diff
> I would like to be able to change the order of the IOHandlers and add some.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message