jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting" <jukka.zitt...@gmail.com>
Subject Re: svn commit: r383856 - in /incubator/jackrabbit/trunk/jackrabbit/src: main/java/org/apache/jackrabbit/core/nodetype/compact/ test/java/org/apache/jackrabbit/core/nodetype/compact/
Date Tue, 07 Mar 2006 12:54:22 GMT
Hi,

On 3/7/06, tripod@apache.org <tripod@apache.org> wrote:
> Modified:
>     incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/nodetype/compact/CompactNodeTypeDefReader.java
> [...]
> @@ -269,7 +270,7 @@
>       * @throws ParseException
>       */
>      private void doSuperTypes(NodeTypeDef ntd) throws ParseException {
> -        ArrayList supertypes = new ArrayList();
> +        HashSet supertypes = new HashSet();
>          if (!currentTokenEquals(Lexer.EXTENDS)) {
>              return;
>          }

This reverts my commit (r383708) that temporarily works around a
problem with supertype ordering (JCR-333). Because of this the
CompactNodeTypeDefTest fails due to supertype ordering at least on
Linux JDK 1.4.2_10.

I suggest we keep my change (use a List instead of a Set) until
JCR-333 is resolved to avoid random problems caused by the undefined
ordering of HashSets.

BR,

Jukka Zitting

--
Yukatan - http://yukatan.fi/ - info@yukatan.fi
Software craftsmanship, JCR consulting, and Java development
Mime
View raw message