Mailing-List: contact jackrabbit-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jackrabbit-dev@incubator.apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Mime-Version: 1.0 (Apple Message framework v746.2)
In-Reply-To: <510143ac0602140523g5daed7fav6ce1288d0398d5f3@mail.gmail.com>
References: <B7962374-2567-4E83-AFE6-1EFA47139795@humanesoftware.com>
 <510143ac0602130204ud9c9879o44efd515ee2eaab@mail.gmail.com>
 <B89321D6-1703-4901-B259-80FBDFA8BA18@humanesoftware.com>
 <6004BC60-0D25-4F19-97CB-5277A8215D8F@humanesoftware.com>
 <3D764F61-8D72-4AB6-A56A-E4A2C2B358B6@humanesoftware.com>
 <510143ac0602140523g5daed7fav6ce1288d0398d5f3@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <08373F67-EDEF-432D-A21C-BB832BA57343@humanesoftware.com>
Content-Transfer-Encoding: 7bit
From: Mark Slater <lists@humanesoftware.com>
Subject: Re: Model-2 Deployment example and test app [Fixed,
 with suggestions for updated docs]
Date: Wed, 15 Feb 2006 01:39:19 -0800
To: jackrabbit-dev@incubator.apache.org


On Feb 14, 2006, at 5:23 AM, Jukka Zitting wrote:

>> I did find one other potential documentation bug in the howto-
>> model1.xml page. The text says
>> [...]
>> I set up a model 1 repository in the same servlet (but with different
>> repository settings) and tried to follow these directions. The
>> problem that I ran into is that the shutdown() method is not in the
>> javax.jcr.Repository interface, and BindableRepository is package
>> protected so I can't even cast the object returned by the Context to
>> a BindableRepository. Without that, I wasn't able to see how the
>> shutdown() method could be called from my servlet's destroy() method.
>
> Good point. Nowadays there's an alternative Repository frontend called
> TransientRepository that solves the shutdown problem by automatically
> closing the repository when all the sessions are closed, but it hasn't
> yet been integrated with BindableRepository. I'll take a look at
> fixing this.

It seems there's an interface in org.apache.jackrabbit.api called  
JackrabbitRepository. Its only method is the prototype for the  
shutdown() method that needs to be called. I tried changing  
BindableRepository implement that, and made the method made public.  
When I did my web app could cast the object it got from the JNDI  
context to a JackrabbitRepository and things worked just fine.

Mark

Index: src/main/java/org/apache/jackrabbit/core/jndi/ 
BindableRepository.java
===================================================================
--- src/main/java/org/apache/jackrabbit/core/jndi/ 
BindableRepository.java       (revision 377972)
+++ src/main/java/org/apache/jackrabbit/core/jndi/ 
BindableRepository.java       (working copy)
@@ -16,6 +16,7 @@
   */
package org.apache.jackrabbit.core.jndi;
+import org.apache.jackrabbit.api.JackrabbitRepository;
import org.apache.jackrabbit.core.RepositoryImpl;
import org.apache.jackrabbit.core.config.RepositoryConfig;
@@ -59,7 +60,7 @@
   * method should be used to explicitly close the repository if
   * needed.
   */
-class BindableRepository implements Repository, Referenceable,  
Serializable {
+class BindableRepository implements Repository,  
JackrabbitRepository, Referenceable, Serializable {
      /** The serialization UID of this class. */
      static final long serialVersionUID = -2298220550793843166L;
@@ -253,7 +254,7 @@
      /**
       * Delegated to the underlying repository instance.
       */
-    void shutdown() {
+    public void shutdown() {
          ((RepositoryImpl) delegatee).shutdown();
          try {
              Runtime.getRuntime().removeShutdownHook(hook);