jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexandru Popescu <the.mindstorm.mailingl...@gmail.com>
Subject Re: [Fwd: [jira] Commented: (JCR-298) missing blob.remove in Berkeley DB persistance manager]
Date Thu, 02 Feb 2006 11:32:42 GMT
Hi!

I am watching the SVN commit notifications and I've seen nothing related to this one.

Agreed, everybody is busy preparing for the 0.9 - 1.0 which I eagerly wait. Still, I have
expected 
to have at least somebody taking a look at the issue. Should I understand that BDB is deprecated
or 
abandonned?

tia,

./alex
--
.w( the_mindstorm )p.


#: Alexandru Popescu changed the world a bit at a time by saying (astral date: 1/31/2006 11:41
AM) :#
> Hi!
> 
> I am wondering if somebody can take a look at this patch and push it in BDB contrib.
I know that 
> you've been busy preparing Jackrabbit for release, and I would appreciate very much your
help to 
> have this fixed.
> 
> 
> tia,
> 
> ./alex
> --
> .w( the_mindstorm )p.
> 
> 
> [ http://issues.apache.org/jira/browse/JCR-298?page=comments#action_12362464 ]
> 
> Alexandru Popescu commented on JCR-298:
> ---------------------------------------
> 
> It looks like this part is missing:
> [code]
> InternalValue[] values = state.getValues();
>          if (values != null) {
>              for (int i = 0; i < values.length; i++) {
>                  InternalValue val = values[i];
>                  if (val != null) {
>                      if (val.getType() == PropertyType.BINARY) {
>                          BLOBFileValue blobVal = (BLOBFileValue) val.internalValue();
>                          // delete internal resource representation of BLOB value
>                          blobVal.delete(true);
>                          // also remove from BLOBStore
>                          String blobId = blobStore.createId((PropertyId) state.getId(),
i);
>                          try {
>                              blobStore.remove(blobId);
>                          } catch (Exception e) {
>                              log.warn("failed to remove from BLOBStore: " + blobId, e);
>                          }
>                      }
>                  }
>              }
>          }
> [/code]
> 
> ./alex
> --
> .w( the_mindstorm )p.
> 
> 
>> missing blob.remove in Berkeley DB persistance manager
>> ------------------------------------------------------
>>
>>          Key: JCR-298
>>          URL: http://issues.apache.org/jira/browse/JCR-298
>>      Project: Jackrabbit
>>         Type: Bug
>>     Versions: 1.0
>>     Reporter: scharles
>>     Priority: Minor
> 
>>
>> org/apache/jackrabbit/core/state/bdb/BerkeleyDBPersistenceManager.destroy(PropertyState
state) does not remove binary file from
>> the BLOBStore (filesystem impl)
> 


Mime
View raw message