Return-Path: Delivered-To: apmail-incubator-jackrabbit-dev-archive@www.apache.org Received: (qmail 80129 invoked from network); 31 Jan 2006 09:34:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 31 Jan 2006 09:34:29 -0000 Received: (qmail 22123 invoked by uid 500); 31 Jan 2006 09:34:27 -0000 Mailing-List: contact jackrabbit-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jackrabbit-dev@incubator.apache.org Delivered-To: mailing list jackrabbit-dev@incubator.apache.org Received: (qmail 22111 invoked by uid 99); 31 Jan 2006 09:34:27 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jan 2006 01:34:27 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [212.249.34.130] (HELO picanmix.dev.day.com) (212.249.34.130) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jan 2006 01:34:25 -0800 Received: from eu-mail.day.com (eu-mail.dev.day.com [10.0.0.30]) by picanmix.dev.day.com (DAY) with ESMTP id k0V9Y3r23413 for ; Tue, 31 Jan 2006 10:34:03 +0100 (MET) Received: from [127.0.0.1] ([10.0.0.60]) by eu-mail.day.com (Lotus Domino Release 5.0.8) with ESMTP id 2006013110340311:2310 ; Tue, 31 Jan 2006 10:34:03 +0100 Message-ID: <43DF2F07.1010407@day.com> Date: Tue, 31 Jan 2006 10:33:59 +0100 From: Felix Meschberger Organization: Day Software User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: jackrabbit-dev@incubator.apache.org Subject: Re: Remove o.a.j.BaseException? References: <510143ac0601310112x43edbfd0rc4232995218f7f81@mail.gmail.com> <90a8d1c00601310120g7c4041cdt557958905004acc2@mail.gmail.com> In-Reply-To: <90a8d1c00601310120g7c4041cdt557958905004acc2@mail.gmail.com> X-MIMETrack: Itemize by SMTP Server on eu-mail/Day(Release 5.0.8 |June 18, 2001) at 01/31/2006 10:34:03 AM, Serialize by Router on eu-mail/Day(Release 5.0.8 |June 18, 2001) at 01/31/2006 10:34:03 AM, Serialize complete at 01/31/2006 10:34:03 AM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi all, +1 for renaming and cause setting support -1 for removing Though the BaseException (or JackrabbitException ??) has no life in itself, it might be usefull to have a catch-all jackrabbit-specific exception, especially since the exception is checked. Regards Felix Stefan Guggisberg schrieb: > On 1/31/06, Jukka Zitting wrote: > >> Hi, >> >> The org.apache.jackrabbit.BaseException class implements the root >> cause mechanism that is also available built-in since Java 1.4. As we >> already require Java 1.4 I propose that we remove the BaseException >> class in favor of the standard Exception. >> >> There are a few cases where the BaseException is explicitly referenced >> like this: >> >> try { >> // do something >> } catch (BaseException e) { >> // generic error handling >> } >> >> Is there a semantic reason for this or could such cases be replaced >> with "catch (Exception e)"? In the former case I propose that a more >> descriptive exception base class is created. >> > > BaseException is the equivalent to RepositoryException. it's used to > distinguish implementation (i.e. jackrabbit) specific exceptions from > jcr api exceptions. > > +1 for renaming it and removing root cause mechanism (leftover from > early implementations that were jre 1.3 compatible). > > -1 for removing it > > cheers > stefan > > >> BR, >> >> Jukka Zitting >> >> -- >> Yukatan - http://yukatan.fi/ - info@yukatan.fi >> Software craftmanship, JCR consulting, and Java development >> >>