From jackrabbit-dev-return-5008-apmail-incubator-jackrabbit-dev-archive=www.apache.org@incubator.apache.org Tue Jan 03 10:44:53 2006 Return-Path: Delivered-To: apmail-incubator-jackrabbit-dev-archive@www.apache.org Received: (qmail 45321 invoked from network); 3 Jan 2006 10:44:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 3 Jan 2006 10:44:53 -0000 Received: (qmail 61546 invoked by uid 500); 3 Jan 2006 10:44:51 -0000 Mailing-List: contact jackrabbit-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jackrabbit-dev@incubator.apache.org Delivered-To: mailing list jackrabbit-dev@incubator.apache.org Received: (qmail 61535 invoked by uid 99); 3 Jan 2006 10:44:51 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2006 02:44:51 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [212.249.34.130] (HELO picanmix.dev.day.com) (212.249.34.130) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2006 02:44:51 -0800 Received: from eu-mail.day.com (eu-mail.dev.day.com [10.0.0.30]) by picanmix.dev.day.com (DAY) with ESMTP id k03AiSF18719 for ; Tue, 3 Jan 2006 11:44:28 +0100 (MET) Received: from [127.0.0.1] ([10.0.0.79]) by eu-mail.day.com (Lotus Domino Release 5.0.8) with ESMTP id 2006010311442635:6471 ; Tue, 3 Jan 2006 11:44:26 +0100 Message-ID: <43BA5582.7040406@day.com> Date: Tue, 03 Jan 2006 11:44:18 +0100 From: Felix Meschberger Organization: Day Software User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: jackrabbit-dev Subject: JCR-RMI Iterator support X-MIMETrack: Itemize by SMTP Server on eu-mail/Day(Release 5.0.8 |June 18, 2001) at 01/03/2006 11:44:26 AM, Serialize by Router on eu-mail/Day(Release 5.0.8 |June 18, 2001) at 01/03/2006 11:44:28 AM, Serialize complete at 01/03/2006 11:44:28 AM Content-Type: multipart/mixed; boundary="------------040003070005060104080608" X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --------------040003070005060104080608 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-15; format=flowed Hi Jukka, To provide for extensibility of the JCR-RMI implementation I suggest to make the MAX_BUFFER_SIZE field and optimizeIterator method protected in the ServerAdapterFactory class. What do you think ? Find attached a patch file with the suggested modification. Regards Felix --------------040003070005060104080608 Content-Transfer-Encoding: 7bit Content-Type: text/plain; name="jcr-rmi.fm.20060103.diff" Content-Disposition: inline; filename="jcr-rmi.fm.20060103.diff" Index: S:/src/jackrabbit/jackrabbit/contrib/jcr-rmi/src/java/org/apache/jackrabbit/rmi/server/ServerAdapterFactory.java =================================================================== --- S:/src/jackrabbit/jackrabbit/contrib/jcr-rmi/src/java/org/apache/jackrabbit/rmi/server/ServerAdapterFactory.java (revision 365588) +++ S:/src/jackrabbit/jackrabbit/contrib/jcr-rmi/src/java/org/apache/jackrabbit/rmi/server/ServerAdapterFactory.java (working copy) @@ -94,7 +94,7 @@ /** * The default maximum buffer size used for local iterator buffers. */ - private static final int MAX_BUFFER_SIZE = 100; + protected static final int MAX_BUFFER_SIZE = 100; /** * Creates a {@link ServerRepository ServerRepository} instance. @@ -318,7 +318,7 @@ * @return optimized remote iterator * @throws RemoteException on RMI errors */ - private RemoteIterator optimizeIterator(RemoteIterator remote) + protected RemoteIterator optimizeIterator(RemoteIterator remote) throws RemoteException { Object[] elements = remote.nextObjects(); long size = remote.getSize(); --------------040003070005060104080608--