Return-Path: Delivered-To: apmail-incubator-jackrabbit-dev-archive@www.apache.org Received: (qmail 82821 invoked from network); 12 Dec 2005 23:06:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 12 Dec 2005 23:06:12 -0000 Received: (qmail 20514 invoked by uid 500); 12 Dec 2005 23:06:11 -0000 Mailing-List: contact jackrabbit-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jackrabbit-dev@incubator.apache.org Delivered-To: mailing list jackrabbit-dev@incubator.apache.org Received: (qmail 20495 invoked by uid 99); 12 Dec 2005 23:06:10 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Dec 2005 15:06:10 -0800 X-ASF-Spam-Status: No, hits=1.4 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: 207.7.108.211 is neither permitted nor denied by domain of the.mindstorm.mailinglist@gmail.com) Received: from [207.7.108.211] (HELO jervis.textdrive.com) (207.7.108.211) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Dec 2005 15:06:10 -0800 Received: from [192.168.51.118] (unknown [193.121.88.241]) by jervis.textdrive.com (Postfix) with ESMTP id BE7EA67FBE for ; Mon, 12 Dec 2005 23:06:21 +0000 (GMT) Message-ID: <439E0208.6070301@gmail.com> Date: Tue, 13 Dec 2005 01:04:40 +0200 From: Alexandru Popescu User-Agent: Thunderbird 1.5 (Windows/20051025) MIME-Version: 1.0 To: jackrabbit-dev@incubator.apache.org Subject: Re: BindableRepository profiling and suggested patch References: <439A3D4D.4090203@gmail.com> <439D40B4.5040205@gmx.net> In-Reply-To: <439D40B4.5040205@gmx.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N #: Marcel Reutegger changed the world a bit at a time by saying on 12/12/2005 11:19 AM :# > Hi Alex, > > thanks for the suggestion. makes sense to me. > > +1 > > regards > marcel > Any news about it? ./alex -- .w( the_mindstorm )p. > Alexandru Popescu wrote: >> Hi! >> >> I've been profiling an application using Jackrabbit by means of >> BindableRepository. I have noticed that on consequetive redeployments a >> lot of memory is not freed (check the attached picture). >> As you can notice a lot of this space is used by java.lang.Shutdown >> which keeps the shutdown hooks. >> >> The application has context listeners that are correctly unregistering >> the BindableRepository (using RegistryHelper). >> >> My proposed patch is the following: >> >> 1/ keep the shutdown hook thread in the BindableRepository after init is >> called; >> 2/ if the BindableRepository.shutdown is correctly called by means of >> RegistryHelper than remove the shutdown hook >> >> Attached is also the patch generated upon BindableRepository v.307128. >> >> >> What is your opinion on this? >> >> ./alex >> -- >> .w( the_mindstorm )p. >> >> >> > >