Return-Path: Delivered-To: apmail-incubator-jackrabbit-dev-archive@www.apache.org Received: (qmail 40694 invoked from network); 8 Dec 2005 09:07:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 8 Dec 2005 09:07:56 -0000 Received: (qmail 65952 invoked by uid 500); 8 Dec 2005 09:07:55 -0000 Mailing-List: contact jackrabbit-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jackrabbit-dev@incubator.apache.org Delivered-To: mailing list jackrabbit-dev@incubator.apache.org Received: (qmail 65941 invoked by uid 99); 8 Dec 2005 09:07:55 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2005 01:07:55 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [212.249.34.130] (HELO picanmix.dev.day.com) (212.249.34.130) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2005 01:07:54 -0800 Received: from eu-mail.day.com (eu-mail.dev.day.com [10.0.0.30]) by picanmix.dev.day.com (DAY) with ESMTP id jB897XO14110 for ; Thu, 8 Dec 2005 10:07:33 +0100 (MET) Received: from [10.0.0.72] ([10.0.0.72]) by eu-mail.day.com (Lotus Domino Release 5.0.8) with ESMTP id 2005120810073176:13378 ; Thu, 8 Dec 2005 10:07:31 +0100 Message-ID: <4397F7D4.2050705@day.com> Date: Thu, 08 Dec 2005 10:07:32 +0100 From: Angela Schreiber User-Agent: Mozilla Thunderbird 0.8 (Windows/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: jackrabbit-dev@incubator.apache.org Subject: Re: svn commit: r354822 - /incubator/jackrabbit/trunk/contrib/jcr-server/server/src/java/org/apache/jackrabbit/webdav/simple/ResourceFactoryImpl.java References: <20051207182047.85755.qmail@minotaur.apache.org> In-Reply-To: <20051207182047.85755.qmail@minotaur.apache.org> X-MIMETrack: Itemize by SMTP Server on eu-mail/Day(Release 5.0.8 |June 18, 2001) at 12/08/2005 10:07:31 AM, Serialize by Router on eu-mail/Day(Release 5.0.8 |June 18, 2001) at 12/08/2005 10:07:32 AM, Serialize complete at 12/08/2005 10:07:32 AM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N hi brian bcm@apache.org wrote: > Author: bcm > Date: Wed Dec 7 10:20:44 2005 > New Revision: 354822 > > we also add accessors for the lockManager and resourceConfig > attributes and make them non-final so that other objects can modify > them. hm.... i don't agree. the resourcefactory is created once in the simple-servlet and should use the config and the lockManager obtain from the correspond get-methods in the simple servlet. they should not be reset later on and therefore i dislike the setters in the ResourceFactory. i think 'final' was correct. what are your reason for changing this? maybe i'm simply missing something? regards angela