jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexandru Popescu <the.mindstorm.mailingl...@gmail.com>
Subject Re: BindableRepository profiling and suggested patch
Date Mon, 12 Dec 2005 23:04:40 GMT
#: Marcel Reutegger changed the world a bit at a time by saying on  12/12/2005 11:19 AM :#
> Hi Alex,
> 
> thanks for the suggestion. makes sense to me.
> 
> +1
> 
> regards
>   marcel
> 


Any news about it?

./alex
--
.w( the_mindstorm )p.

> Alexandru Popescu wrote:
>> Hi!
>> 
>> I've been profiling an application using Jackrabbit by means of 
>> BindableRepository. I have noticed that on consequetive redeployments a 
>> lot of memory is not freed (check the attached picture).
>> As you can notice a lot of this space is used by java.lang.Shutdown 
>> which keeps the shutdown hooks.
>> 
>> The application has context listeners that are correctly unregistering 
>> the BindableRepository (using RegistryHelper).
>> 
>> My proposed patch is the following:
>> 
>> 1/ keep the shutdown hook thread in the BindableRepository after init is 
>> called;
>> 2/ if the BindableRepository.shutdown is correctly called by means of 
>> RegistryHelper than remove the shutdown hook
>> 
>> Attached is also the patch generated upon BindableRepository v.307128.
>> 
>> 
>> What is your opinion on this?
>> 
>> ./alex
>> -- 
>> .w( the_mindstorm )p.
>> 
>> 
>> 
> 
> 


Mime
View raw message