jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Angela Schreiber <anch...@day.com>
Subject Re: svn commit: r354818 - /incubator/jackrabbit/trunk/contrib/jcr-server/server/src/java/org/apache/jackrabbit/webdav/simple/ResourceConfig.java
Date Thu, 08 Dec 2005 11:27:14 GMT
hi brian

please apologize, but i start feeling a little embarrassed.

one aim of the config was, to remove the hardcoded check
in the simple/DavResourceImpl, which repository nodes
should be treated as webdav collection resources and which
represent a normal resource.

the current configuration allows to define either the
collection nodetypes or the non-collection nodetypes...
thats what i considered to be the useful cases and which
of cause is just one way to look at it and i'm not saying
i found the only and not even the best way to deal with

now to your change: you define that the root node
should always be a collection. of cause this is the
desired result, because otherwise you won't get huge
benefit out of your webdav.

but i don't agree that it's correct to hardcode it
into the ResourceConfig. if it turns out that the config
as is does provide enough flexibility and you run
into problems (thus your configuration resulted in a
non-collection root), i'd say that the way the config was
designed is wrong and should be reviewed.

maybe you can explain, what kind of troubles you had
with the configuration as is?

thanks for your comprehension

bcm@apache.org wrote:
> Author: bcm
> Date: Wed Dec  7 09:48:29 2005
> New Revision: 354818
> URL: http://svn.apache.org/viewcvs?rev=354818&view=rev
> Log:
> always treat the root node as a collection resource.

> --- incubator/jackrabbit/trunk/contrib/jcr-server/server/src/java/org/apache/jackrabbit/webdav/simple/ResourceConfig.java
> +++ incubator/jackrabbit/trunk/contrib/jcr-server/server/src/java/org/apache/jackrabbit/webdav/simple/ResourceConfig.java
Wed Dec  7 09:48:29 2005
> @@ -200,6 +200,10 @@
>              boolean isCollection = true;
>              Node n = (Node)item;
>              try {
> +                if (n.getPath().equals("/")) {
> +                    // the root node always represents a collection
> +                    return true;
> +                }

View raw message