jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Angela Schreiber <anch...@day.com>
Subject Re: svn commit: r354822 - /incubator/jackrabbit/trunk/contrib/jcr-server/server/src/java/org/apache/jackrabbit/webdav/simple/ResourceFactoryImpl.java
Date Thu, 08 Dec 2005 09:07:32 GMT
hi brian

bcm@apache.org wrote:
> Author: bcm
> Date: Wed Dec  7 10:20:44 2005
> New Revision: 354822

> we also add accessors for the lockManager and resourceConfig
> attributes and make them non-final so that other objects can modify
> them.

hm.... i don't agree. the resourcefactory is created once in
the simple-servlet and should use the config and the lockManager
obtain from the correspond get-methods in the simple servlet.

they should not be reset later on and therefore i dislike the
setters in the ResourceFactory. i think 'final' was correct.

what are your reason for changing this? maybe i'm simply
missing something?


View raw message