Mailing-List: contact jackrabbit-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jackrabbit-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of gazarenkov@gmail.com designates
 66.249.82.192 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:reply-to:to:references:subject:date:mime-version:content-type:content-transfer-encoding:x-priority:x-msmail-priority:x-mailer:x-mimeole:from;
        b=TQV7PXTPJTbpe9BNX5hmsPV7tK3ZipJbJUEcIdNtKrKTC9HttDt3OlVKiprN+UJAckjo6ss+M1RVgZYEyK10ziQoco5I9dSnOzPC8Q/GhwxH6JgBHvZnSX1XZ7nc+u+3a0nyBIJ0OohAdg3m1TmMt8ZHz8uoVM9Fq5t1LTrdko8=
Message-ID: <003b01c5f1a8$8b2f74b0$bb0e020a@Gennady>
Reply-To: "Gennady Azarenkov" <gennady.azarenkov@exoplatform.com>
To: <jackrabbit-dev@incubator.apache.org>
References: <00fe01c5ee98$7b76cc70$bb0e020a@Gennady>
 <4386D25D.6000206@gmx.net>
Subject: Re: TCK: SessionTest.testMoveItemExistsException()
Date: Fri, 25 Nov 2005 12:11:01 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="koi8-r";
	reply-type=response
Content-Transfer-Encoding: 7bit
From: Gennady Azarenkov <gazarenkov@gmail.com>

hi Marcel,

> first of all, sorry for the delay but I was busy with some other work.
it's ok, i am just beginning to think that it is a wrong place for TCK 
questions :)

it seems there is s situation like this here

org.apache.jackrabbit.test.api.SetPropertyAssumeTypeTest.testValueConstraintVioloationExceptionBecauseOfInvalidTypeParameter(SetPropertyAssumeTypeTest.java:445)

and here

org.apache.jackrabbit.test.api.SetPropertyAssumeTypeTest.testStringConstraintVioloationExceptionBecauseOfInvalidTypeParameter(SetPropertyAssumeTypeTest.java:479)

test tries to set date property with "abc" value and i have
ValueFormatException instead of ConstraintViolationException in our impl

take a look pls,

regards,
gena

Gennady Azarenkov

eXo platform

----- Original Message ----- 
From: "Marcel Reutegger" <marcel.reutegger@gmx.net>
To: <jackrabbit-dev@incubator.apache.org>
Sent: Friday, November 25, 2005 10:59 AM
Subject: Re: TCK: SessionTest.testMoveItemExistsException()


> Hi Gennady,
>
> first of all, sorry for the delay but I was busy with some other work.
>
> you are right, the exception declarations with their documentation are not 
> 100% clear. The test should therefore only create a situation where a 
> ItemExistsException can be thrown.
>
> Thanks for the suggestion. I have changed the test case accordingly in svn 
> revision: 348915
>
> regards
>  marcel
>
> Gennady Azarenkov wrote:
>> hi,
>>
>> it seems to me that SessionTest.testMoveItemExistsException() is not 
>> completely correct:
>>
>> here testNodeType is "nt:unstructured"
>> Node moveNode = srcParentNode.addNode(nodeName2, testNodeType);
>>
>> here getProperty("nodetype2") is "nt:folder"
>> Node destParentNode = defaultRootNode.addNode(nodeName3, 
>> getProperty("nodetype2"));
>> // add a valid child
>> Node destNode = destParentNode.addNode(nodeName2, 
>> getProperty("nodetype3"));
>>
>> So,
>> superuser.move(moveNode.getPath(), destNode.getPath());
>> can throw ConstraintViolationException (not only ItemExistsException)
>> because of attempt to add node of nt:unstructured type to nt:folder 
>> parent and it is depend on
>> implementation what will be thrown in fact (our impl throws 
>> ConstraintViolationException first :) ).
>>
>> i would replace
>> Node moveNode = srcParentNode.addNode(nodeName2, testNodeType);
>> with
>> Node moveNode = srcParentNode.addNode(nodeName2, 
>> getProperty("nodetype3"));
>>
>> regards,
>> gena
>>
>> Gennady Azarenkov
>> eXo platform
>>