Mailing-List: contact jackrabbit-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jackrabbit-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of marcel.reutegger@gmx.net
 designates 213.165.64.20 as permitted sender)
Message-ID: <4340E587.5050805@gmx.net>
Date: Mon, 03 Oct 2005 10:02:15 +0200
From: Marcel Reutegger <marcel.reutegger@gmx.net>
User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
MIME-Version: 1.0
To: jackrabbit-dev@incubator.apache.org
Subject: Re: Suggestion for TCK test SaveTest.testSave
References: <5F266C8676DF1241BED644C210ABFD1901F53B3E@usilms28.ca.com>
In-Reply-To: <5F266C8676DF1241BED644C210ABFD1901F53B3E@usilms28.ca.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi Doug,

makes sense to me to change the test case. Though the spec is imo not 
100% clear about this. But I don't see a reason why an implementation 
shouldn't be allowed to use a subtype of nt:query.

changed as suggested, svn revision: 293273

thanks for reporting this issue.

regards
  marcel

McComsey, Doug wrote:
> I am failing this TCK test: 
>     org.apache.jackrabbit.test.api.query.SaveTest.testSave
> 
> One of the checks is to insure that the query node is of type nt:query:
> 
>     assertEquals("Query node is not of type nt:query", 
>                   ntQuery, queryNode.getPrimaryNodeType().getName());
> 
> I would like to suggest that it be:
> 
>     assertTrue("Query node is not of type nt:query",
>                 queryNode.isNodeType(ntQuery));
> 
> I fail this test because my node definition is not nt:query but instead has nt:query as a supertype. I would pass the suggested test.
> 
> Doug McComsey
> Computer Associates
> doug.mccomsey@ca.com
>  
> 
> 
>