jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcel Reutegger <marcel.reuteg...@gmx.net>
Subject Re: Suggestion for TCK test SaveTest.testSave
Date Mon, 03 Oct 2005 08:02:15 GMT
Hi Doug,

makes sense to me to change the test case. Though the spec is imo not 
100% clear about this. But I don't see a reason why an implementation 
shouldn't be allowed to use a subtype of nt:query.

changed as suggested, svn revision: 293273

thanks for reporting this issue.

regards
  marcel

McComsey, Doug wrote:
> I am failing this TCK test: 
>     org.apache.jackrabbit.test.api.query.SaveTest.testSave
> 
> One of the checks is to insure that the query node is of type nt:query:
> 
>     assertEquals("Query node is not of type nt:query", 
>                   ntQuery, queryNode.getPrimaryNodeType().getName());
> 
> I would like to suggest that it be:
> 
>     assertTrue("Query node is not of type nt:query",
>                 queryNode.isNodeType(ntQuery));
> 
> I fail this test because my node definition is not nt:query but instead has nt:query
as a supertype. I would pass the suggested test.
> 
> Doug McComsey
> Computer Associates
> doug.mccomsey@ca.com
>  
> 
> 
> 

Mime
View raw message