jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (JCR-142) allow subclassing of NodeTypeReader
Date Tue, 20 Sep 2005 15:25:33 GMT
     [ http://issues.apache.org/jira/browse/JCR-142?page=all ]
Jukka Zitting resolved JCR-142:

    Fix Version: 1.0
     Resolution: Fixed

I'm sorry for not acting on this issue sooner. I was a bit occupied at times during the summer
and didn't really notice this issue until now.

The changes you proposed were committed in revision 290470 with some modifications. I actually
made the main NodeTypeReader methods public instead protected to facilitate composition in
addition to inheritance as an extension mechanism. I also didn't change any of the DOMWalker
functionality as the getNamespaces() method should always return the namespace registrations
of the *current* element. Instead i changed the NodeTypeReader to cache the top-level namespaces
as a private property that is accessible through the proposed getter method.

Thanks for reporting the issue! I hope that the committed changes cover the functionality
you need, even if the issue was pending so long.

> allow subclassing of NodeTypeReader
> -----------------------------------
>          Key: JCR-142
>          URL: http://issues.apache.org/jira/browse/JCR-142
>      Project: Jackrabbit
>         Type: Improvement
>   Components: nodetype
>     Reporter: Brian Moseley
>     Assignee: Jukka Zitting
>      Fix For: 1.0
>  Attachments: nodetypereader.patch
> in working towards an offline tool to import custom namespaces and node types, i found
that i needed to make some small changes to NodeTypeReader and DOMWalker so that i could subclass
NodeTypeReader and access the namespaces specified in the node type definition file. see the
attached patch.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message