jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Guggisberg <stefan.guggisb...@gmail.com>
Subject Re: ValueFactoryTest.testValueFormatException issues incorrect message
Date Tue, 02 Aug 2005 08:46:56 GMT
On 8/1/05, McComsey, Doug <Doug.Mccomsey@ca.com> wrote:
> Minor point on the TCK test class ValueFactoryTest, method testValueFormatException.
> 
> Many of the tests issue this message:
> 
>       fail("Conversion from String " + nameValueFail
>            + " to a Date value should throw ValueFormatException.");
> 
> Unfortunately the same message is issued for Date, Double, Long, Name, and Path. It looks
like the old cloned message problem (Thank God I've never done that ☺.)
> 
> I suggest the message be changed to indicate the correct type or, better still, use PropertyType.nameFromValue
to derive it from types[i].

fixed as suggested (r226972), thanks!

cheers
stefan 

> 
> Regards,
> Doug
> 
> Doug McComsey
> Computer Associates
> doug.mccomsey@ca.com
> 
> 
>
Mime
View raw message