jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcel Reutegger <marcel.reuteg...@gmx.net>
Subject Re: Very small bug in TextPlainTextFilter ?
Date Thu, 16 Jun 2005 11:47:24 GMT
oops... yes, you are right. should be == 1 of course.

thanks

fixed in revision: 190900

regards
  marcel

Cédric Damioli wrote:
> Hi all,
> 
> Seeing recent threads about TextFilters, I took a look into indexing 
> stuff and noticed the following code in TextPlainTextFilter.doFilter() :
> 
>        if (values.length > 0) {
>            .........
>        } else {
>            // multi value not supported
>            throw new RepositoryException("Multi-valued binary properties 
> not supported.");
>        }
> 
> 
> IMHO, the test
> if (values.length == 1) { ....}
> 
> would be more appropriate with the else statement
> 
> I don't opened a JIRA issue (it is quite trivial), but I can do if 
> necessary.
> 
> But I may also have missed something ?
> 
> Regards,
> Cédric
> 

Mime
View raw message