jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-116) JavaCC grammar generation to ${maven.build.dir}/generated-src
Date Thu, 12 May 2005 14:01:13 GMT
     [ http://issues.apache.org/jira/browse/JCR-116?page=comments#action_65127 ]
Jukka Zitting commented on JCR-116:

I had a look at the Maven Eclipse plugin sources, and it seems that the plugin will add all
subdirectories of ${maven.gen.src} to an Eclipse project. Thus adding the following line to
project.properties makes the generated source directories automatically available in Eclipse:


This seems to work fine with "maven eclipse", but does not work with the Eclipse Mevenide
plugin nor does it seem to work with the Maven IDEA plugin.

This issue seems to boil down to a source tree clarity vs. IDE convenience question. I'd vote
for the former, but I'm a "maven eclipse" user so the change has little drawbacks for me.

> JavaCC grammar generation to ${maven.build.dir}/generated-src
> -------------------------------------------------------------
>          Key: JCR-116
>          URL: http://issues.apache.org/jira/browse/JCR-116
>      Project: Jackrabbit
>         Type: Wish
>   Components: maven, xpath, sql
>     Reporter: Jukka Zitting
>     Priority: Minor
>  Attachments: jackrabbit-javacc-target-patch.txt
> Currently the JavaCC grammars in src/grammar/{xpath,sql} are processed into Java source
files in src/java/org/apache/jacrabbit/core/query/{xpath,sql} where we also have normal version
controlled source files. This leads to the need to maintain special svn:ignore properties
and also the more general issue of mixing manually written and automatically generated source
files. Because of this the "maven clean" command does not (at the moment) truly restore your
source tree to a "fresh checkout" state.
> I'm proposing (as a wish, you are free to disagree) that the JavaCC grammars be generated
into Java files within the Maven build directory. The attached patch modifies the javacc maven
goals to generate files into ${maven.build.dir}/generated-src. The modified prepare-filesystem
goal also adds the generated source path ${maven.build.dir}/generated-src/main/java into the
maven compile set so that the generated sources are included in the normal builds.
> PS. There are a couple of JavaCC generated files that have been intentionally modified
for Jackrabbit. The ant:delete commands at the end of the jacrabbit:generate-*-parser goals
specifically remove these generated files. It would however be nicer if custom modifications
would not be needed.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message