jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-116) JavaCC grammar generation to ${maven.build.dir}/generated-src
Date Mon, 09 May 2005 18:49:04 GMT
     [ http://issues.apache.org/jira/browse/JCR-116?page=comments#action_64767 ]
     
Jukka Zitting commented on JCR-116:
-----------------------------------

Fabrizio Giustina wrote:
> the maven eclipse plugin DOES add addiction paths for generated files,
> but only if you are using maven in order to generate java source files.

Oh, nice! Thanks for the information!

When I created the attached patch I first tried using the Maven JavaCC plugin. I ran into
a problem with how to handle the XSLT-generated XPath grammar files and decided to just skip
the plugin.

Might it be feasible to try again, now that there's a clear added benefit in using the Maven
plugin?


> JavaCC grammar generation to ${maven.build.dir}/generated-src
> -------------------------------------------------------------
>
>          Key: JCR-116
>          URL: http://issues.apache.org/jira/browse/JCR-116
>      Project: Jackrabbit
>         Type: Wish
>   Components: maven, sql, xpath
>     Reporter: Jukka Zitting
>     Priority: Minor
>  Attachments: jackrabbit-javacc-target-patch.txt
>
> Currently the JavaCC grammars in src/grammar/{xpath,sql} are processed into Java source
files in src/java/org/apache/jacrabbit/core/query/{xpath,sql} where we also have normal version
controlled source files. This leads to the need to maintain special svn:ignore properties
and also the more general issue of mixing manually written and automatically generated source
files. Because of this the "maven clean" command does not (at the moment) truly restore your
source tree to a "fresh checkout" state.
> I'm proposing (as a wish, you are free to disagree) that the JavaCC grammars be generated
into Java files within the Maven build directory. The attached patch modifies the javacc maven
goals to generate files into ${maven.build.dir}/generated-src. The modified prepare-filesystem
goal also adds the generated source path ${maven.build.dir}/generated-src/main/java into the
maven compile set so that the generated sources are included in the normal builds.
> PS. There are a couple of JavaCC generated files that have been intentionally modified
for Jackrabbit. The ant:delete commands at the end of the jacrabbit:generate-*-parser goals
specifically remove these generated files. It would however be nicer if custom modifications
would not be needed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message