Return-Path: Delivered-To: apmail-incubator-jackrabbit-dev-archive@www.apache.org Received: (qmail 95131 invoked from network); 21 Apr 2005 13:08:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 21 Apr 2005 13:08:39 -0000 Received: (qmail 97680 invoked by uid 500); 21 Apr 2005 13:08:51 -0000 Mailing-List: contact jackrabbit-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jackrabbit-dev@incubator.apache.org Delivered-To: mailing list jackrabbit-dev@incubator.apache.org Received: (qmail 97667 invoked by uid 99); 21 Apr 2005 13:08:51 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from 93sirius042.dc.ukrtel.net (HELO 93sirius042.dc.ukrtel.net) (195.5.55.42) by apache.org (qpsmtpd/0.28) with ESMTP; Thu, 21 Apr 2005 06:08:51 -0700 Received: from max.office (max.office [192.168.0.71]) by 93sirius042.dc.ukrtel.net (Postfix) with ESMTP id 00B689CC1C for ; Thu, 21 Apr 2005 16:08:31 +0300 (EEST) Date: Thu, 21 Apr 2005 16:08:31 +0300 From: Maxim X-Mailer: The Bat! (v1.61) Reply-To: Maxim X-Priority: 3 (Normal) Message-ID: <852223867.20050421160831@anahoret.com> To: jackrabbit-dev@incubator.apache.org Subject: TCK question MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hello jackrabbit-dev. In the file: /jackrabbit/src/test/org/apache/jackrabbit/test/api/BooleanPropertyTest.java from line 52 it says: ----------------------------------------------------------- public void testValue() throws RepositoryException { if (multiple) { try { prop.getBoolean(); fail("Property.getBoolean() called on a multivalue property " + "should throw a ValueFormatException."); } catch (ValueFormatException vfe) { // ok } } boolean bool = prop.getValue().getBoolean(); boolean otherBool = prop.getBoolean(); assertTrue("Value.getBoolean() and Property.getBoolean() " + "return different values.", bool == otherBool) ; } ----------------------------------------------------------- As far as I understand the specification, if current property is indeed multi-valued, calling call prop.getValue() should throw ValueFormatException. So, shouldn't it say instead: ----------------------------------------------------------- public void testValue() throws RepositoryException { if (multiple) { try { prop.getBoolean(); fail("Property.getBoolean() called on a multivalue property " + "should throw a ValueFormatException."); } catch (ValueFormatException vfe) { // ok } } else { boolean bool = prop.getValue().getBoolean(); boolean otherBool = prop.getBoolean(); assertTrue("Value.getBoolean() and Property.getBoolean() " + "return different values.", bool == otherBool) ; } } ----------------------------------------------------------- Thank you. -- Best regards, Maxim. Anahoret Team.