jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Guggisberg (JIRA)" <j...@apache.org>
Subject [jira] Closed: (JCR-114) Suggestion regarding NodeImpl and PropertyImpl in jackrabbit.core
Date Sun, 24 Apr 2005 17:12:25 GMT
     [ http://issues.apache.org/jira/browse/JCR-114?page=all ]
     
Stefan Guggisberg closed JCR-114:
---------------------------------

    Resolution: Fixed

cleaned up NodeImpl & PropertyImpl as suggested (r164448)


> Suggestion regarding NodeImpl and PropertyImpl in jackrabbit.core
> -----------------------------------------------------------------
>
>          Key: JCR-114
>          URL: http://issues.apache.org/jira/browse/JCR-114
>      Project: Jackrabbit
>         Type: Improvement
>   Components: API
>     Reporter: angela
>     Assignee: Stefan Guggisberg
>     Priority: Trivial

>
> Both NodeImpl and PropertyImpl contain in their respective setProperty/setValue (respectively)
initial validation checks, that is indentical across the various
> variants of each and could possibly in either case be place in a separate method.
> in NodeImpl.setProperty (also: addMixin, removeMixin, orderBefore):
> - sanityCheck
> - is-parent-checked-out
> - is-not-protected (missing for setProperty ???)
> - is-parent-not-locked
> in PropertyImpl.setValue:
> - sanityCheck
> - is-parent-checked-out
> - is-not-protected 
> - is-value-compatible-with-multivalue-definition (NOTE: check opposite for setting single
>   or multiple values)
> - is-parent-not-locked
> Second, i'm never sure, in which case ChildNode, ChildProperty is prefered 
> over Node/Property (as present in the jcr api)...
> regards
> angela

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message