Return-Path: Delivered-To: apmail-incubator-jackrabbit-dev-archive@www.apache.org Received: (qmail 68370 invoked from network); 18 Mar 2005 10:21:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 18 Mar 2005 10:21:36 -0000 Received: (qmail 6317 invoked by uid 500); 18 Mar 2005 10:21:35 -0000 Mailing-List: contact jackrabbit-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jackrabbit-dev@incubator.apache.org Delivered-To: mailing list jackrabbit-dev@incubator.apache.org Received: (qmail 6304 invoked by uid 99); 18 Mar 2005 10:21:35 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from server2.jahia.com (HELO server2.jahia.com) (80.74.132.69) by apache.org (qpsmtpd/0.28) with ESMTP; Fri, 18 Mar 2005 02:21:34 -0800 Received: (qmail 22881 invoked from network); 18 Mar 2005 10:21:31 -0000 Received: from line-zh-113-140.adsl.econophone.ch (HELO ?127.0.0.1?) (212.53.113.140) by server2.jahia.com with AES256-SHA encrypted SMTP; 18 Mar 2005 10:21:31 -0000 Message-ID: <423AABB0.6080200@jahia.com> Date: Fri, 18 Mar 2005 11:21:36 +0100 From: Serge Huber User-Agent: Mozilla Thunderbird 1.0.1 (Windows/20050309) X-Accept-Language: en-us, en MIME-Version: 1.0 To: jackrabbit-dev@incubator.apache.org Subject: Re: Bug in HibernatePersistenceManager? References: <42399FC3.5090108@wegmueller.com> In-Reply-To: <42399FC3.5090108@wegmueller.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Yes you are correct. Actually for consistency, I think the code should rather be : InternalValue blobValue = InternalValue.create(in); as it was provided by Edgar in his OJB patch. Regards, Serge Huber. Thomas Wegmueller wrote: > Hi list, > > i'm new to Jackrabbit and just played around with orm-persistence and > there with Hibernate. Could it be that i found a bug in > HibernatePersistenceManager? > > Shouldn't it read: > > Index: HibernatePersistenceManager.java > =================================================================== > --- HibernatePersistenceManager.java (revision 156775) > +++ HibernatePersistenceManager.java (working copy) > @@ -180,7 +180,7 @@ > ByteArrayInputStream in = new > ByteArrayInputStream( > ormBlobValue.getBlobValue()); > try { > - BLOBFileValue blobValue = new > BLOBFileValue(in); > + InternalValue blobValue = > InternalValue.create( new BLOBFileValue(in),PropertyType.BINARY, null ); > internalValueList.add(blobValue); > } catch (Throwable t) { > throw new ItemStateException( > > > as later the interalValueList is stored in an array of type > InternalValue[], and BLOBFileValue is not an InternalValue. > > Or am i missing something? > > Thanks, > Thomas >