jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Guggisberg <stefan.guggisb...@gmail.com>
Subject Re: [PATCH] log4j to commons-logging conversion
Date Wed, 16 Feb 2005 09:25:14 GMT
hi manoj,

On Tue, 15 Feb 2005 19:30:43 -0800 (PST), Manoj Prasad
<manoj_ca@yahoo.com> wrote:
> Hi,
> 
> I saw this mentioned in the ToDo.txt file and thought
> I would give it a try. I wrote a Perl script that did
> it all automatically except for LogPrintWriter.java
> which I updated manually. There is no API to "Level"
> in commons-logging, so I deleted it - please confirm
> that's Ok.
> 
> I didn't do any additional testing except what maven
> does automatically. Given the simplicity of the
> change, that seemed to be enough.
> 

thank you very much for the patch! the changes look
trivial enough but what i am a bit worried about is 
the sheer scope of the changes as almost every 
single file has been touched. i don't know much 
about commons-logging, only that it allows to use 
various logging services underneath. 

one question that i have for example is about 
configuration. how is commons-logging being
configured?

also, i assume that log4j would not be a compile-time 
dependency anymore, but still a run-time dependency.
is that correct?

> Let me know if you want me to post the Perl script or
> you require anything else.

posting the perl script would be great.

thanks again for your help, it's very appreciated.

cheers
stefan

> 
> Thanks.
> Manoj
> 
> 
> __________________________________________________
> Do You Yahoo!?
> Tired of spam?  Yahoo! Mail has the best spam protection around
> http://mail.yahoo.com
> 
>

Mime
View raw message