jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpfis...@apache.org
Subject svn commit: r1297569 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/mk/store/CopyingGC.java test/java/org/apache/jackrabbit/mk/store/CopyHeadRevisionTest.java
Date Tue, 06 Mar 2012 16:46:27 GMT
Author: dpfister
Date: Tue Mar  6 16:46:26 2012
New Revision: 1297569

URL: http://svn.apache.org/viewvc?rev=1297569&view=rev
Log:
Add copying GC for revisions
- Update TODOs


Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/store/CopyingGC.java
    jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/mk/store/CopyHeadRevisionTest.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/store/CopyingGC.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/store/CopyingGC.java?rev=1297569&r1=1297568&r2=1297569&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/store/CopyingGC.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/store/CopyingGC.java
Tue Mar  6 16:46:26 2012
@@ -30,7 +30,11 @@ import org.apache.jackrabbit.mk.util.IOU
 
 /**
  * Revision garbage collector that copies reachable revisions from a "from" revision
- * store to a "to" revision store. 
+ * store to a "to" revision store. It assumes that both stores share the same blob
+ * store.
+ * 
+ * TODO: Ensure the integrity of the parental relationship when copying revisions
+ *       in a GC cycle (because there may be missing intermediate commits).
  */
 public class CopyingGC implements RevisionStore, Closeable {
     
@@ -77,7 +81,7 @@ public class CopyingGC implements Revisi
     public void stop() {
         running = false;
         
-        // TODO: swap rsFrom/rsTo and re-initialize
+        // TODO: swap rsFrom/rsTo and reset them
         rsFrom = rsTo;
         rsTo = null;
     }

Modified: jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/mk/store/CopyHeadRevisionTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/mk/store/CopyHeadRevisionTest.java?rev=1297569&r1=1297568&r2=1297569&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/mk/store/CopyHeadRevisionTest.java
(original)
+++ jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/mk/store/CopyHeadRevisionTest.java
Tue Mar  6 16:46:26 2012
@@ -33,10 +33,7 @@ import org.junit.Test;
  * Use-case: start off a new revision store that contains just the head revision
  * and its nodes.
  * 
- * TODO: if copying starts at some point in time and ends some time later, copy
- *       all revisions that are accessed in the meantime to the new store.
- *       This must be done in a way that ensures the integrity of the parental
- *       relationship (because there may be missing intermediate commits).
+ * TODO: make the test concurrent
  */
 public class CopyHeadRevisionTest {
 



Mime
View raw message