jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mdue...@apache.org
Subject svn commit: r1166138 [2/12] - in /jackrabbit/sandbox/jackrabbit-mk: jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/ jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/batch/ jackrabbit-spi-commons/src/main/ja...
Date Wed, 07 Sep 2011 12:00:20 GMT
Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/ItemInfoBuilder.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/ItemInfoBuilder.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/ItemInfoBuilder.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/ItemInfoBuilder.java Wed Sep  7 12:00:14 2011
@@ -16,9 +16,6 @@
  */
 package org.apache.jackrabbit.spi.commons;
 
-import static org.apache.jackrabbit.spi.commons.iterator.Iterators.filterIterator;
-import static org.apache.jackrabbit.spi.commons.iterator.Iterators.transformIterator;
-
 import org.apache.jackrabbit.spi.ChildInfo;
 import org.apache.jackrabbit.spi.ItemInfo;
 import org.apache.jackrabbit.spi.Name;
@@ -39,7 +36,6 @@ import org.apache.jackrabbit.spi.commons
 
 import javax.jcr.PropertyType;
 import javax.jcr.RepositoryException;
-
 import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
@@ -50,6 +46,9 @@ import java.util.Calendar;
 import java.util.Iterator;
 import java.util.List;
 
+import static org.apache.jackrabbit.spi.commons.iterator.Iterators.filterIterator;
+import static org.apache.jackrabbit.spi.commons.iterator.Iterators.transformIterator;
+
 /**
  * Utility class providing a {@link NodeInfoBuilder} for building {@link NodeInfo}.
  * Example usage:
@@ -75,11 +74,10 @@ import java.util.List;
 public final class ItemInfoBuilder {
 
     private ItemInfoBuilder() {
-        super();
     }
 
     /**
-     * Same as <code>nodeInfoBuilder("", listener)</code>
+     * Same as {@code nodeInfoBuilder("", listener)}
      * @param listener
      * @return
      */
@@ -88,7 +86,7 @@ public final class ItemInfoBuilder {
     }
 
     /**
-     * Same as <code>nodeInfoBuilder("", null)</code>
+     * Same as {@code nodeInfoBuilder("", null)}
      * @return
      */
     public static NodeInfoBuilder nodeInfoBuilder() {
@@ -96,7 +94,7 @@ public final class ItemInfoBuilder {
     }
 
     /**
-     * Same as <code>nodeInfoBuilder(localName, null)</code>
+     * Same as {@code nodeInfoBuilder(localName, null)}
      * @param localName
      * @return
      */
@@ -105,7 +103,7 @@ public final class ItemInfoBuilder {
     }
 
     /**
-     * Return a {@link NodeInfoBuilder} for a node with a given <code>localName</code>.
+     * Return a {@link NodeInfoBuilder} for a node with a given {@code localName}.
      * @param localName  localName of the node
      * @param listener  {@link Listener} to receive notifications about {@link NodeInfo}s,
      *                  {@link PropertyInfo}s and {@link ChildInfo}s built.
@@ -116,7 +114,7 @@ public final class ItemInfoBuilder {
     }
 
     /**
-     * Return a {@link NodeInfoBuilder} for a node with a given <code>name</code>.
+     * Return a {@link NodeInfoBuilder} for a node with a given {@code name}.
      * @param name  name of the node
      * @param listener  {@link Listener} to receive notifications about {@link NodeInfo}s,
      *                  {@link PropertyInfo}s and {@link ChildInfo}s built.
@@ -139,13 +137,13 @@ public final class ItemInfoBuilder {
 
         /**
          * Notification that new {@link ChildInfo}s have been built.
-         * @param id  Id of the parent to which the <code>childInfos</code> belong
+         * @param id  Id of the parent to which the {@code childInfos} belong
          * @param childInfos
          */
         void createChildInfos(NodeId id, Iterator<ChildInfo> childInfos);
 
         /**
-         * Notification that a new {@link PropertyInfo} has been bult.
+         * Notification that a new {@link PropertyInfo} has been built.
          * @param propertyInfo
          */
         void createPropertyInfo(PropertyInfo propertyInfo);
@@ -174,26 +172,24 @@ public final class ItemInfoBuilder {
         private NodeInfo nodeInfo;
 
         private NodeInfoBuilder(NodeInfoBuilder nodeInfoBuilder, String localName, Listener listener) {
-            super();
             parent = nodeInfoBuilder;
             this.localName = localName;
             this.listener = listener;
         }
 
         private NodeInfoBuilder(NodeInfoBuilder nodeInfoBuilder, Name name, Listener listener) {
-            super();
             parent = nodeInfoBuilder;
             this.name = name;
             this.listener = listener;
         }
 
         /**
-         * Create a new child {@link PropertyInfo} with a given <code>localName</code> and a given
-         * <code>value</code> of type <code>String</code> on this {@link NodeInfo}.
+         * Create a new child {@link PropertyInfo} with a given {@code localName} and a given
+         * {@code value} of type {@code String} on this {@link NodeInfo}.
          *
          * @param localName
          * @param value
-         * @return  <code>this</code>
+         * @return  {@code this}
          * @throws RepositoryException
          */
         public PropertyInfoBuilder createPropertyInfo(String localName, String value) throws RepositoryException {
@@ -204,10 +200,10 @@ public final class ItemInfoBuilder {
 
         /**
          * Create a new child {@link PropertyInfo} with a given
-         * <code>localName</code> on this {@link NodeInfo}.
+         * {@code localName} on this {@link NodeInfo}.
          *
          * @param localName
-         * @return  <code>this</code>
+         * @return  {@code this}
          */
         public PropertyInfoBuilder createPropertyInfo(String localName) {
             return new PropertyInfoBuilder(this, localName, listener);
@@ -216,16 +212,16 @@ public final class ItemInfoBuilder {
         /**
          * Create a new child {@link PropertyInfo} on this {@link NodeInfo}.
          *
-         * @return  <code>this</code>
+         * @return  {@code this}
          */
         public PropertyInfoBuilder createPropertyInfo() {
             return new PropertyInfoBuilder(this, null, listener);
         }
 
         /**
-         * Create a new child {@link NodeInfo} on this NodeInfo with a given <code>localName</code>.
+         * Create a new child {@link NodeInfo} on this NodeInfo with a given {@code localName}.
          * @param localName
-         * @return  <code>this</code>
+         * @return  {@code this}
          */
         public NodeInfoBuilder createNodeInfo(String localName) {
             return new NodeInfoBuilder(this, localName, listener);
@@ -234,14 +230,14 @@ public final class ItemInfoBuilder {
         /**
          * Create a new child {@link NodeInfo} on this NodeInfo.
 
-         * @return  <code>this</code>
+         * @return  {@code this}
          */
         public NodeInfoBuilder createNodeInfo() {
             return new NodeInfoBuilder(this, (String) null, listener);
         }
 
         /**
-         * Set the <code>name</code> of the node
+         * Set the {@code name} of the node
          *
          * @param name
          * @return
@@ -252,7 +248,7 @@ public final class ItemInfoBuilder {
         }
 
         /**
-         * Set the <code>localName</code> of the node
+         * Set the {@code localName} of the node
          *
          * @param localName
          * @return
@@ -402,7 +398,7 @@ public final class ItemInfoBuilder {
          * Add a {@link PropertyInfo}
          *
          * @param propertyInfo
-         * @return <code>this</code>
+         * @return {@code this}
          */
         public NodeInfoBuilder addPropertyInfo(PropertyInfo propertyInfo) {
             itemInfos.add(propertyInfo);
@@ -413,7 +409,7 @@ public final class ItemInfoBuilder {
          * Add a {@link NodeInfo}
          *
          * @param nodeInfo
-         * @return <code>this</code>
+         * @return {@code this}
          */
         public NodeInfoBuilder addNodeInfo(NodeInfo nodeInfo) {
             itemInfos.add(nodeInfo);
@@ -450,11 +446,13 @@ public final class ItemInfoBuilder {
         private Iterator<ChildInfo> getChildInfos() {
             return transformIterator(filterIterator(itemInfos.iterator(),
                     new Predicate<ItemInfo>(){
+                        @Override
                         public boolean evaluate(ItemInfo info) {
                             return info.denotesNode();
                         }
                     }),
                     new Transformer<ItemInfo, ChildInfo>(){
+                        @Override
                         public ChildInfo transform(ItemInfo info) {
                             return new ChildInfoImpl(
                                     info.getPath().getName(), null,
@@ -466,11 +464,13 @@ public final class ItemInfoBuilder {
         private Iterator<PropertyId> getPropertyIds() {
             return transformIterator(filterIterator(itemInfos.iterator(),
                     new Predicate<ItemInfo>(){
+                        @Override
                         public boolean evaluate(ItemInfo info) {
                             return !info.denotesNode();
                         }
                     }),
                     new Transformer<ItemInfo, PropertyId>(){
+                        @Override
                         public PropertyId transform(ItemInfo info) {
                             return (PropertyId) info.getId();
                         }
@@ -498,14 +498,13 @@ public final class ItemInfoBuilder {
         private PropertyInfo propertyInfo;
 
         private PropertyInfoBuilder(NodeInfoBuilder nodeInfoBuilder, String localName, Listener listener) {
-            super();
             parent = nodeInfoBuilder;
             this.localName = localName;
             this.listener = listener;
         }
 
         /**
-         * Set the <code>name</code> of this property
+         * Set the {@code name} of this property
          *
          * @param name
          * @return
@@ -516,7 +515,7 @@ public final class ItemInfoBuilder {
         }
 
         /**
-         * Set the <code>localName</code> of this property
+         * Set the {@code localName} of this property
          *
          * @param localName
          * @return
@@ -538,14 +537,14 @@ public final class ItemInfoBuilder {
         }
 
         /**
-         * Set the <code>{@link PropertyType type}</code> of this property
+         * Set the {@code }{@link PropertyType type}</code> of this property
          *
          * @param type
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws IllegalStateException  if a property of a different type has been added before.
          */
         public PropertyInfoBuilder setType(int type) {
-            if (values.size() > 0 && type != values.get(0).getType()) {
+            if (!values.isEmpty() && type != values.get(0).getType()) {
                 throw new IllegalStateException("Type mismatch. " +
                         "Required " + PropertyType.nameFromValue(values.get(0).getType()) +
                         " found " + PropertyType.nameFromValue(type));
@@ -556,11 +555,11 @@ public final class ItemInfoBuilder {
         }
 
         /**
-         * Add a <code>value</code> to this property. Sets this property to single valued if
+         * Add a {@code value} to this property. Sets this property to single valued if
          * this is the first value. Otherwise sets this property to multi-valued.
          *
          * @param value
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws IllegalStateException  if the type of the value does not match the type of this property
          */
         public PropertyInfoBuilder addValue(QValue value) {
@@ -581,7 +580,7 @@ public final class ItemInfoBuilder {
          * Add a {@link PropertyType#STRING} value to this property.
          *
          * @param value
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws RepositoryException
          * @throws IllegalStateException  if the type of the value does not match the type of this property
          */
@@ -593,7 +592,7 @@ public final class ItemInfoBuilder {
          * Add a {@link PropertyType#DATE} value to this property.
          *
          * @param value
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws RepositoryException
          * @throws IllegalStateException  if the type of the value does not match the type of this property
          */
@@ -605,7 +604,7 @@ public final class ItemInfoBuilder {
          * Add a {@link PropertyType#DOUBLE} value to this property.
          *
          * @param value
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws RepositoryException
          * @throws IllegalStateException  if the type of the value does not match the type of this property
          */
@@ -617,7 +616,7 @@ public final class ItemInfoBuilder {
          * Add a {@link PropertyType#LONG} value to this property.
          *
          * @param value
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws RepositoryException
          * @throws IllegalStateException  if the type of the value does not match the type of this property
          */
@@ -629,7 +628,7 @@ public final class ItemInfoBuilder {
          * Add a {@link PropertyType#BOOLEAN} value to this property.
          *
          * @param value
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws RepositoryException
          * @throws IllegalStateException  if the type of the value does not match the type of this property
          */
@@ -641,7 +640,7 @@ public final class ItemInfoBuilder {
          * Add a {@link PropertyType#NAME} value to this property.
          *
          * @param value
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws RepositoryException
          * @throws IllegalStateException  if the type of the value does not match the type of this property
          */
@@ -653,7 +652,7 @@ public final class ItemInfoBuilder {
          * Add a {@link PropertyType#PATH} value to this property.
          *
          * @param value
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws RepositoryException
          * @throws IllegalStateException  if the type of the value does not match the type of this property
          */
@@ -665,7 +664,7 @@ public final class ItemInfoBuilder {
          * Add a {@link PropertyType#DECIMAL} value to this property.
          *
          * @param value
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws RepositoryException
          * @throws IllegalStateException  if the type of the value does not match the type of this property
          */
@@ -677,7 +676,7 @@ public final class ItemInfoBuilder {
          * Add a {@link PropertyType#URI} value to this property.
          *
          * @param value
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws RepositoryException
          * @throws IllegalStateException  if the type of the value does not match the type of this property
          */
@@ -689,7 +688,7 @@ public final class ItemInfoBuilder {
          * Add a {@link PropertyType#BINARY} value to this property.
          *
          * @param value
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws RepositoryException
          * @throws IllegalStateException  if the type of the value does not match the type of this property
          */
@@ -701,7 +700,7 @@ public final class ItemInfoBuilder {
          * Add a {@link PropertyType#BINARY} value to this property.
          *
          * @param value
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws RepositoryException
          * @throws IllegalStateException  if the type of the value does not match the type of this property
          */
@@ -713,7 +712,7 @@ public final class ItemInfoBuilder {
          * Add a {@link PropertyType#BINARY} value to this property.
          *
          * @param value
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws RepositoryException
          * @throws IllegalStateException  if the type of the value does not match the type of this property
          */
@@ -725,7 +724,7 @@ public final class ItemInfoBuilder {
          * Set this property to multi-values.
          *
          * @param on
-         * @return <code>this</code>
+         * @return {@code this}
          * @throws IllegalStateException if this property does not contain exactly on value
          */
         public PropertyInfoBuilder setMultivalued(boolean on) {

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/ItemInfoCacheImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/ItemInfoCacheImpl.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/ItemInfoCacheImpl.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/ItemInfoCacheImpl.java Wed Sep  7 12:00:14 2011
@@ -33,8 +33,8 @@ import org.apache.jackrabbit.spi.Reposit
  * from the cache.
  *
  * The underlying idea here is, that {@link ItemInfo}s which are supplied by the
- * <code>RepositoryService</code> but not immediately needed are put into the
- * cache to avoid further round trips to <code>RepositoryService</code>.
+ * {@code RepositoryService} but not immediately needed are put into the
+ * cache to avoid further round trips to {@code RepositoryService}.
  * When they are needed later, they are read from the cache. There is no need to
  * keep them in this cache after that point since they are present in the
  * hierarchy from then on.
@@ -62,17 +62,17 @@ public class ItemInfoCacheImpl implement
      * @param cacheSize
      */
     public ItemInfoCacheImpl(int cacheSize) {
-        super();
         this.cacheSize = cacheSize;
         entries = new LinkedMap(cacheSize);
     }
 
     /**
      * This implementation removes the item from the cache
-     * if it is present. Furthermore if the <code>nodeId</code>
-     * id uuid based, and no item is found by the <code>nodeId</code>
+     * if it is present. Furthermore if the {@code nodeId}
+     * id uuid based, and no item is found by the {@code nodeId}
      * a second lookup is done by the path.
      */
+    @Override
     public Entry<NodeInfo> getNodeInfo(NodeId nodeId) {
         Object entry = entries.remove(nodeId);
         if (entry == null) {
@@ -87,10 +87,11 @@ public class ItemInfoCacheImpl implement
 
     /**
      * This implementation removes the item from the cache
-     * if it is present. Furthermore if the <code>propertyId</code>
-     * id uuid based, and no item is found by the <code>propertyId</code>
+     * if it is present. Furthermore if the {@code propertyId}
+     * id uuid based, and no item is found by the {@code propertyId}
      * a second lookup is done by the path.
      */
+    @Override
     public Entry<PropertyInfo> getPropertyInfo(PropertyId propertyId) {
         Object entry = entries.remove(propertyId);
         if (entry == null) {
@@ -107,6 +108,7 @@ public class ItemInfoCacheImpl implement
      * This implementation cached the item by its id and if the id
      * is uuid based but has no path, also by its path.
      */
+    @Override
     public void put(ItemInfo info, long generation) {
         ItemId id = info.getId();
         Entry<? extends ItemInfo> entry = info.denotesNode()
@@ -119,6 +121,7 @@ public class ItemInfoCacheImpl implement
         }
     }
 
+    @Override
     public void dispose() {
         entries.clear();
     }

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/ItemInfoImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/ItemInfoImpl.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/ItemInfoImpl.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/ItemInfoImpl.java Wed Sep  7 12:00:14 2011
@@ -17,14 +17,12 @@
 package org.apache.jackrabbit.spi.commons;
 
 import org.apache.jackrabbit.spi.ItemInfo;
-import org.apache.jackrabbit.spi.Name;
 import org.apache.jackrabbit.spi.Path;
-import org.apache.jackrabbit.spi.NodeId;
 
 import java.io.Serializable;
 
 /**
- * <code>ItemInfoImpl</code> is a base class for <code>ItemInfo</code>
+ * {@code ItemInfoImpl} is a base class for {@code ItemInfo}
  * implementations.
  */
 public abstract class ItemInfoImpl implements ItemInfo, Serializable {
@@ -50,16 +48,12 @@ public abstract class ItemInfoImpl imple
         this.isNode = isNode;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean denotesNode() {
         return isNode;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public Path getPath() {
         return path;
     }

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/LockInfoImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/LockInfoImpl.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/LockInfoImpl.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/LockInfoImpl.java Wed Sep  7 12:00:14 2011
@@ -22,7 +22,7 @@ import org.apache.jackrabbit.spi.NodeId;
 import java.io.Serializable;
 
 /**
- * <code>LockInfoImpl</code> implements a serializable <code>LockInfo</code>
+ * {@code LockInfoImpl} implements a serializable {@code LockInfo}
  * based on another lock info.
  */
 public class LockInfoImpl implements LockInfo, Serializable {
@@ -58,20 +58,20 @@ public class LockInfoImpl implements Loc
     private final boolean isLockOwner;
 
     /**
-     * The <code>NodeId</code> of the locked node.
+     * The {@code NodeId} of the locked node.
      */
     private final NodeId nodeId;
 
     /**
-     * Creates a new lock info for the given <code>lock</code> info.
+     * Creates a new lock info for the given {@code lock} info.
      *
      * @param lockToken the lock token
      * @param lockOwner the lock owner
      * @param isDeep whether this lock is deep or not
      * @param isSessionScoped whether this lock is session scoped or not
      * @param secondsRemaining Number of seconds until the lock timeout is reached.
-     * @param isLockOwner <code>true</code> if the calling session is lock
-     * owner; <code>false</code> otherwise.
+     * @param isLockOwner {@code true} if the calling session is lock
+     * owner; {@code false} otherwise.
      * @param nodeId the node id of the locked node.
      * @since JCR 2.0
      */
@@ -87,51 +87,37 @@ public class LockInfoImpl implements Loc
         this.nodeId = nodeId;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public String getLockToken() {
         return lockToken;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public String getOwner() {
         return lockOwner;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean isDeep() {
         return isDeep;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean isSessionScoped() {
         return isSessionScoped;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public long getSecondsRemaining() {
         return secondsRemaining;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean isLockOwner() {
         return isLockOwner;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public NodeId getNodeId() {
         return nodeId;
     }

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/NodeInfoImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/NodeInfoImpl.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/NodeInfoImpl.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/NodeInfoImpl.java Wed Sep  7 12:00:14 2011
@@ -17,21 +17,19 @@
 package org.apache.jackrabbit.spi.commons;
 
 import org.apache.jackrabbit.spi.ChildInfo;
-import org.apache.jackrabbit.spi.IdFactory;
 import org.apache.jackrabbit.spi.Name;
 import org.apache.jackrabbit.spi.NodeId;
 import org.apache.jackrabbit.spi.NodeInfo;
 import org.apache.jackrabbit.spi.Path;
 import org.apache.jackrabbit.spi.PropertyId;
 
-import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Iterator;
 import java.util.List;
 
 /**
- * <code>NodeInfoImpl</code> implements a serializable <code>NodeInfo</code>
+ * {@code NodeInfoImpl} implements a serializable {@code NodeInfo}
  * based on another node info.
  */
 public class NodeInfoImpl extends ItemInfoImpl implements NodeInfo {
@@ -115,52 +113,37 @@ public class NodeInfoImpl extends ItemIn
 
     //-------------------------------< NodeInfo >-------------------------------
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public NodeId getId() {
         return id;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public int getIndex() {
         return index;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public Name getNodetype() {
         return primaryTypeName;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public Name[] getMixins() {
         return mixinNames;
     }
 
-    /**
-     * {@inheritDoc}
-     */
     public PropertyId[] getReferences() {
         return references.toArray(new PropertyId[references.size()]);
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public Iterator<PropertyId> getPropertyIds() {
         return propertyIds.iterator();
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public Iterator<ChildInfo> getChildInfos() {
-        return (childInfos == null) ? null : childInfos.iterator();
+        return childInfos == null ? null : childInfos.iterator();
     }
 }

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/PropertyInfoImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/PropertyInfoImpl.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/PropertyInfoImpl.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/PropertyInfoImpl.java Wed Sep  7 12:00:14 2011
@@ -16,19 +16,18 @@
  */
 package org.apache.jackrabbit.spi.commons;
 
-import org.apache.jackrabbit.spi.PropertyInfo;
-import org.apache.jackrabbit.spi.PropertyId;
-import org.apache.jackrabbit.spi.QValue;
-import org.apache.jackrabbit.spi.NodeId;
 import org.apache.jackrabbit.spi.IdFactory;
-import org.apache.jackrabbit.spi.Name;
+import org.apache.jackrabbit.spi.NodeId;
 import org.apache.jackrabbit.spi.Path;
+import org.apache.jackrabbit.spi.PropertyId;
+import org.apache.jackrabbit.spi.PropertyInfo;
+import org.apache.jackrabbit.spi.QValue;
 
 import java.io.Serializable;
 
 /**
- * <code>PropertyInfoImpl</code> implements a serializable
- * <code>PropertyInfo</code> based on another property info.
+ * {@code PropertyInfoImpl} implements a serializable
+ * {@code PropertyInfo} based on another property info.
  */
 public class PropertyInfoImpl extends ItemInfoImpl implements PropertyInfo {
 
@@ -54,7 +53,7 @@ public class PropertyInfoImpl extends It
 
     /**
      * Creates a new serializable property info for the given
-     * <code>PropertyInfo</code>.
+     * {@code PropertyInfo}.
      *
      * @param propertyInfo
      */
@@ -86,36 +85,28 @@ public class PropertyInfoImpl extends It
     public PropertyInfoImpl(Path path, PropertyId id, int type,
                             boolean isMultiValued, QValue[] values) {
         super(path, false);
-        this.propertyId = id;
+        propertyId = id;
         this.type = type;
         this.isMultiValued = isMultiValued;
         this.values = values;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public PropertyId getId() {
         return propertyId;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public int getType() {
         return type;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean isMultiValued() {
         return isMultiValued;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public QValue[] getValues() {
         QValue[] vals = new QValue[values.length];
         System.arraycopy(values, 0, vals, 0, values.length);

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QItemDefinitionImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QItemDefinitionImpl.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QItemDefinitionImpl.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QItemDefinitionImpl.java Wed Sep  7 12:00:14 2011
@@ -16,15 +16,13 @@
  */
 package org.apache.jackrabbit.spi.commons;
 
-import org.apache.jackrabbit.spi.QItemDefinition;
-import org.apache.jackrabbit.spi.QNodeDefinition;
-import org.apache.jackrabbit.spi.QPropertyDefinition;
 import org.apache.jackrabbit.spi.Name;
+import org.apache.jackrabbit.spi.QItemDefinition;
 
 import java.io.Serializable;
 
 /**
- * This abstract class implements the <code>QItemDefinition</code>
+ * This abstract class implements the {@code QItemDefinition}
  * interface and additionally provides setter methods for the
  * various item definition attributes.
  */
@@ -63,13 +61,13 @@ public abstract class QItemDefinitionImp
     /**
      * HashCode of this object
      */
-    protected transient int hashCode = 0;
+    protected transient int hashCode;
 
     /**
-     * Creates a new <code>QItemDefinitionImpl</code>.
+     * Creates a new {@code QItemDefinitionImpl}.
      *
      * @param name              the name of the child item.
-     * @param declaringNodeType the delaring node type
+     * @param declaringNodeType the declaring node type
      * @param isAutoCreated     if this item is auto created.
      * @param isMandatory       if this is a mandatory item.
      * @param onParentVersion   the on parent version behaviour.
@@ -80,71 +78,58 @@ public abstract class QItemDefinitionImp
                         int onParentVersion, boolean isProtected) {
         this.name = name;
         this.declaringNodeType = declaringNodeType;
-        this.autoCreated = isAutoCreated;
-        this.mandatory = isMandatory;
+        autoCreated = isAutoCreated;
+        mandatory = isMandatory;
         this.onParentVersion = onParentVersion;
-        this.writeProtected = isProtected;
+        writeProtected = isProtected;
     }
 
     //--------------------------------------------------------------< QItemDefinition >
-    /**
-     * {@inheritDoc}
-     */
+
+    @Override
     public Name getDeclaringNodeType() {
         return declaringNodeType;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public Name getName() {
         return name;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean isAutoCreated() {
         return autoCreated;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public int getOnParentVersion() {
         return onParentVersion;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean isProtected() {
         return writeProtected;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean isMandatory() {
         return mandatory;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean definesResidual() {
         return Name.NS_DEFAULT_URI.equals(name.getNamespaceURI()) && "*".equals(name.getLocalName());
     }
 
     //-------------------------------------------< java.lang.Object overrides >
     /**
-     * Compares two item definitions for equality. Returns <code>true</code>
+     * Compares two item definitions for equality. Returns {@code true}
      * if the given object is an item definition and has the same attributes
      * as this item definition.
      *
      * @param obj the object to compare this item definition with
-     * @return <code>true</code> if the object is equal to this item definition,
-     *         <code>false</code> otherwise
+     * @return {@code true} if the object is equal to this item definition,
+     *         {@code false} otherwise
      * @see Object#equals(Object)
      */
     @Override
@@ -166,9 +151,6 @@ public abstract class QItemDefinitionImp
         return false;
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public int hashCode() {
         int h = 17;

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QNodeDefinitionImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QNodeDefinitionImpl.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QNodeDefinitionImpl.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QNodeDefinitionImpl.java Wed Sep  7 12:00:14 2011
@@ -16,23 +16,21 @@
  */
 package org.apache.jackrabbit.spi.commons;
 
-import org.apache.jackrabbit.spi.QNodeDefinition;
 import org.apache.jackrabbit.spi.Name;
+import org.apache.jackrabbit.spi.QNodeDefinition;
 import org.apache.jackrabbit.spi.commons.conversion.NameException;
 import org.apache.jackrabbit.spi.commons.conversion.NamePathResolver;
 import org.apache.jackrabbit.spi.commons.name.NameConstants;
 
-import java.util.Arrays;
-import java.util.TreeSet;
-import java.util.Set;
-import java.util.HashSet;
-
 import javax.jcr.NamespaceException;
 import javax.jcr.nodetype.NodeDefinition;
 import javax.jcr.nodetype.NodeType;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Set;
 
 /**
- * <code>QNodeDefinitionImpl</code> implements a <code>QNodeDefinition</code>.
+ * {@code QNodeDefinitionImpl} implements a {@code QNodeDefinition}.
  */
 public class QNodeDefinitionImpl extends QItemDefinitionImpl implements QNodeDefinition {
 
@@ -95,16 +93,16 @@ public class QNodeDefinitionImpl extends
     }
 
     /**
-     * Creates a new node definition based on a JCR <code>NodeDefinition</code>.
+     * Creates a new node definition based on a JCR {@code NodeDefinition}.
      *
      * @param nodeDef  the node definition.
      * @param resolver the name/path resolver of the session that provided the
      *                 node definition
-     * @throws NameException      if <code>nodeDef</code> contains an illegal
+     * @throws NameException      if {@code nodeDef} contains an illegal
      *                            name.
-     * @throws NamespaceException if <code>nodeDef</code> contains a name with
+     * @throws NamespaceException if {@code nodeDef} contains a name with
      *                            an namespace prefix that is unknown to
-     *                            <code>resolver</code>.
+     *                            {@code resolver}.
      */
     public QNodeDefinitionImpl(NodeDefinition nodeDef,
                                NamePathResolver resolver)
@@ -119,45 +117,36 @@ public class QNodeDefinitionImpl extends
     }
 
     //----------------------------------------------------< QNodeDefinition >---
-    /**
-     * {@inheritDoc}
-     */
+
+    @Override
     public Name getDefaultPrimaryType() {
         return defaultPrimaryType;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public Name[] getRequiredPrimaryTypes() {
         return requiredPrimaryTypes.toArray(new Name[requiredPrimaryTypes.size()]);
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean allowsSameNameSiblings() {
         return allowsSameNameSiblings;
     }
 
-    /**
-     * {@inheritDoc}
-     *
-     * @return always <code>true</code>
-     */
+    @Override
     public boolean definesNode() {
         return true;
     }
 
     //-------------------------------------------------------------< Object >---
     /**
-     * Compares two node definitions for equality. Returns <code>true</code>
+     * Compares two node definitions for equality. Returns {@code true}
      * if the given object is a node definition and has the same attributes
      * as this node definition.
      *
      * @param obj the object to compare this node definition with
-     * @return <code>true</code> if the object is equal to this node definition,
-     *         <code>false</code> otherwise
+     * @return {@code true} if the object is equal to this node definition,
+     *         {@code false} otherwise
      * @see Object#equals(Object)
      */
     @Override
@@ -203,11 +192,11 @@ public class QNodeDefinitionImpl extends
      *
      * @param nt       the node types
      * @param resolver the name/path resolver of the session that provided
-     *                 <code>nt</code>.
+     *                 {@code nt}.
      * @return the names of the node types.
      * @throws NameException      if a node type returns an illegal name.
      * @throws NamespaceException if the name of a node type contains a prefix
-     *                            that is not known to <code>resolver</code>.
+     *                            that is not known to {@code resolver}.
      */
     private static Name[] getNodeTypeNames(NodeType[] nt,
                                            NamePathResolver resolver)

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QNodeTypeDefinitionImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QNodeTypeDefinitionImpl.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QNodeTypeDefinitionImpl.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QNodeTypeDefinitionImpl.java Wed Sep  7 12:00:14 2011
@@ -47,7 +47,7 @@ import java.util.Set;
 import java.io.Serializable;
 
 /**
- * <code>QNodeTypeDefinitionImpl</code> implements a serializable SPI node
+ * {@code QNodeTypeDefinitionImpl} implements a serializable SPI node
  * type definition.
  */
 public class QNodeTypeDefinitionImpl implements QNodeTypeDefinition, Serializable {
@@ -65,7 +65,7 @@ public class QNodeTypeDefinitionImpl imp
     private final Name[] supertypes;
 
     /**
-     * The names of the supported mixins on this node type (or <code>null</code>)
+     * The names of the supported mixins on this node type (or {@code null})
      */
     private final Name[] supportedMixins;
 
@@ -90,7 +90,7 @@ public class QNodeTypeDefinitionImpl imp
     private final boolean hasOrderableChildNodes;
 
     /**
-     * The name of the primary item or <code>null</code> if none is defined.
+     * The name of the primary item or {@code null} if none is defined.
      */
     private final Name primaryItemName;
 
@@ -105,7 +105,7 @@ public class QNodeTypeDefinitionImpl imp
     private final Set<QNodeDefinition> childNodeDefs;
 
     /**
-     * Unmodifiable collection of dependent node type <code>Name</code>s.
+     * Unmodifiable collection of dependent node type {@code Name}s.
      * Calculated on demand.
      *
      * @see #getDependencies()
@@ -137,14 +137,14 @@ public class QNodeTypeDefinitionImpl imp
      *
      * @param name                   the name of the node type
      * @param supertypes             the names of the supertypes
-     * @param supportedMixins        the names of supported mixins (or <code>null</code>)
+     * @param supportedMixins        the names of supported mixins (or {@code null})
      * @param isMixin                if this is a mixin node type
      * @param isAbstract             if this is an abstract node type definition.
      * @param isQueryable            if this is a queryable node type definition.
      * @param hasOrderableChildNodes if this node type has orderable child
      *                               nodes.
      * @param primaryItemName        the name of the primary item, or
-     *                               <code>null</code>.
+     *                               {@code null}.
      * @param declaredPropDefs       the declared property definitions.
      * @param declaredNodeDefs       the declared child node definitions.
      */
@@ -165,8 +165,8 @@ public class QNodeTypeDefinitionImpl imp
         this.isQueryable = isQueryable;
         this.hasOrderableChildNodes = hasOrderableChildNodes;
         this.primaryItemName = primaryItemName;
-        this.propertyDefs = getSerializablePropertyDefs(declaredPropDefs);
-        this.childNodeDefs = getSerializableNodeDefs(declaredNodeDefs);
+        propertyDefs = getSerializablePropertyDefs(declaredPropDefs);
+        childNodeDefs = getSerializableNodeDefs(declaredNodeDefs);
         // make sure super types are sorted
         SortedSet<Name> types = new TreeSet<Name>();
         types.addAll(Arrays.asList(supertypes));
@@ -174,7 +174,7 @@ public class QNodeTypeDefinitionImpl imp
     }
 
     /**
-     * Createa a new <code>QNodeTypeDefinitionImpl</code> from a JCR
+     * Createa a new {@code QNodeTypeDefinitionImpl} from a JCR
      * NodeType definition.
      *
      * @param def node type definition
@@ -215,16 +215,12 @@ public class QNodeTypeDefinitionImpl imp
 
     //------------------------------------------------< QNodeTypeDefinition >---
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public Name getName() {
         return name;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public Name[] getSupertypes() {
         if (supertypes.length > 0
                 || isMixin() || NameConstants.NT_BASE.equals(getName())) {
@@ -234,58 +230,42 @@ public class QNodeTypeDefinitionImpl imp
         }
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean isMixin() {
         return isMixin;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean isAbstract() {
         return isAbstract;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean isQueryable() {
         return isQueryable;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean hasOrderableChildNodes() {
         return hasOrderableChildNodes;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public Name getPrimaryItemName() {
         return primaryItemName;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public QPropertyDefinition[] getPropertyDefs() {
         return propertyDefs.toArray(new QPropertyDefinition[propertyDefs.size()]);
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public QNodeDefinition[] getChildNodeDefs() {
         return childNodeDefs.toArray(new QNodeDefinition[childNodeDefs.size()]);
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public Collection<Name> getDependencies() {
         if (dependencies == null) {
             Collection<Name> deps = new HashSet<Name>();
@@ -328,9 +308,7 @@ public class QNodeTypeDefinitionImpl imp
         return dependencies;
     }
     
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public Name[] getSupportedMixinTypes() {
         if (supportedMixins == null) {
             return null;
@@ -381,7 +359,7 @@ public class QNodeTypeDefinitionImpl imp
     //-----------------------------------------------------------< internal >---
     /**
      * Returns a set of serializable property definitions for
-     * <code>propDefs</code>.
+     * {@code propDefs}.
      *
      * @param propDefs the SPI property definitions.
      * @return a set of serializable property definitions.
@@ -389,19 +367,13 @@ public class QNodeTypeDefinitionImpl imp
     private static Set<QPropertyDefinition> getSerializablePropertyDefs(
             QPropertyDefinition[] propDefs) {
         Set<QPropertyDefinition> defs = new HashSet<QPropertyDefinition>();
-        for (QPropertyDefinition pd : propDefs) {
-            if (pd instanceof Serializable) {
-                defs.add(pd);
-            } else {
-                defs.add(pd);
-            }
-        }
+        Collections.addAll(defs, propDefs);
         return defs;
     }
 
     /**
      * Returns a set of serializable node definitions for
-     * <code>nodeDefs</code>.
+     * {@code nodeDefs}.
      *
      * @param nodeDefs the node definitions.
      * @return a set of serializable node definitions.

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QPropertyDefinitionImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QPropertyDefinitionImpl.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QPropertyDefinitionImpl.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/QPropertyDefinitionImpl.java Wed Sep  7 12:00:14 2011
@@ -16,9 +16,9 @@
  */
 package org.apache.jackrabbit.spi.commons;
 
+import org.apache.jackrabbit.spi.Name;
 import org.apache.jackrabbit.spi.QPropertyDefinition;
 import org.apache.jackrabbit.spi.QValue;
-import org.apache.jackrabbit.spi.Name;
 import org.apache.jackrabbit.spi.QValueConstraint;
 import org.apache.jackrabbit.spi.QValueFactory;
 import org.apache.jackrabbit.spi.commons.conversion.NamePathResolver;
@@ -26,20 +26,17 @@ import org.apache.jackrabbit.spi.commons
 import org.apache.jackrabbit.spi.commons.nodetype.constraint.ValueConstraint;
 import org.apache.jackrabbit.spi.commons.value.ValueFormat;
 
-import java.util.Arrays;
-import java.util.HashSet;
-import java.util.Set;
-
 import javax.jcr.RepositoryException;
 import javax.jcr.Value;
 import javax.jcr.nodetype.PropertyDefinition;
+import java.util.Arrays;
+import java.util.HashSet;
 
 /**
- * <code>QPropertyDefinitionImpl</code> implements SPI property
+ * {@code QPropertyDefinitionImpl} implements SPI property
  * definition interface.
  */
-public class QPropertyDefinitionImpl extends QItemDefinitionImpl
-        implements QPropertyDefinition {
+public class QPropertyDefinitionImpl extends QItemDefinitionImpl implements QPropertyDefinition {
 
     private static final long serialVersionUID = 1064686456661663541L;
 
@@ -97,12 +94,12 @@ public class QPropertyDefinitionImpl ext
      * Creates a new serializable property definition.
      *
      * @param name              the name of the child item.
-     * @param declaringNodeType the delaring node type
+     * @param declaringNodeType the declaring node type
      * @param isAutoCreated     if this item is auto created.
      * @param isMandatory       if this is a mandatory item.
      * @param onParentVersion   the on parent version behaviour.
      * @param isProtected       if this item is protected.
-     * @param defaultValues     the default values or <code>null</code> if there
+     * @param defaultValues     the default values or {@code null} if there
      *                          are none.
      * @param isMultiple        if this property is multi-valued.
      * @param requiredType      the required type for this property.
@@ -111,9 +108,9 @@ public class QPropertyDefinitionImpl ext
      * @param availableQueryOperators the available query operators
      * @param isFullTextSearchable if this is fulltext searchable
      * @param isQueryOrderable   if this is queryable
-     * @throws NullPointerException if <code>valueConstraints</code> or
-     *                              <code>availableQueryOperators</code> is
-     *                              <code>null</code>.
+     * @throws NullPointerException if {@code valueConstraints} or
+     *                              {@code availableQueryOperators} is
+     *                              {@code null}.
      * @since JCR 2.0
      */
     public QPropertyDefinitionImpl(Name name, Name declaringNodeType,
@@ -134,23 +131,23 @@ public class QPropertyDefinitionImpl ext
             throw new NullPointerException("availableQueryOperators");
         }
         this.defaultValues = defaultValues;
-        this.multiple = isMultiple;
+        multiple = isMultiple;
         this.requiredType = requiredType;
         this.valueConstraints = valueConstraints;
         this.availableQueryOperators = availableQueryOperators;
-        this.fullTextSearchable = isFullTextSearchable;
-        this.queryOrderable = isQueryOrderable;
+        fullTextSearchable = isFullTextSearchable;
+        queryOrderable = isQueryOrderable;
     }
 
     /**
-     * Creates a new property definition based on <code>propDef</code>.
+     * Creates a new property definition based on {@code propDef}.
      *
      * @param propDef       the JCR property definition.
      * @param resolver      the name/path resolver of the session that provided
      *                      the property definition.
      * @param qValueFactory the QValue factory.
      * @throws RepositoryException if an error occurs while reading from
-     *                             <code>propDef</code>.
+     *                             {@code propDef}.
      */
     public QPropertyDefinitionImpl(PropertyDefinition propDef,
                                    NamePathResolver resolver,
@@ -168,73 +165,56 @@ public class QPropertyDefinitionImpl ext
     }
 
     //------------------------------------------------< QPropertyDefinition >---
-    /**
-     * {@inheritDoc}
-     */
+
+    @Override
     public int getRequiredType() {
         return requiredType;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public QValueConstraint[] getValueConstraints() {
         return valueConstraints;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public QValue[] getDefaultValues() {
         return defaultValues;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean isMultiple() {
         return multiple;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public String[] getAvailableQueryOperators() {
         return availableQueryOperators;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean isFullTextSearchable() {
         return fullTextSearchable;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public boolean isQueryOrderable() {
         return queryOrderable;
     }
 
-    /**
-     * {@inheritDoc}
-     *
-     * @return always <code>false</code>
-     */
+    @Override
     public boolean definesNode() {
         return false;
     }
 
     //-------------------------------------------------------------< Object >---
     /**
-     * Compares two property definitions for equality. Returns <code>true</code>
+     * Compares two property definitions for equality. Returns {@code true}
      * if the given object is a property definition and has the same attributes
      * as this property definition.
      *
      * @param obj the object to compare this property definition with
-     * @return <code>true</code> if the object is equal to this property definition,
-     *         <code>false</code> otherwise
+     * @return {@code true} if the object is equal to this property definition,
+     *         {@code false} otherwise
      * @see Object#equals(Object)
      */
     @Override

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/SerializableBatch.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/SerializableBatch.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/SerializableBatch.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/SerializableBatch.java Wed Sep  7 12:00:14 2011
@@ -17,40 +17,31 @@
 package org.apache.jackrabbit.spi.commons;
 
 import org.apache.jackrabbit.spi.Batch;
-import org.apache.jackrabbit.spi.NodeId;
-import org.apache.jackrabbit.spi.QValue;
-import org.apache.jackrabbit.spi.PropertyId;
 import org.apache.jackrabbit.spi.ItemId;
 import org.apache.jackrabbit.spi.Name;
+import org.apache.jackrabbit.spi.NodeId;
+import org.apache.jackrabbit.spi.PropertyId;
+import org.apache.jackrabbit.spi.QValue;
 
 import javax.jcr.RepositoryException;
-import javax.jcr.ValueFormatException;
-import javax.jcr.PathNotFoundException;
-import javax.jcr.AccessDeniedException;
-import javax.jcr.UnsupportedRepositoryOperationException;
-import javax.jcr.ItemNotFoundException;
-import javax.jcr.nodetype.ConstraintViolationException;
-import javax.jcr.nodetype.NoSuchNodeTypeException;
-import javax.jcr.lock.LockException;
-import javax.jcr.version.VersionException;
 import java.io.Serializable;
-import java.util.List;
 import java.util.ArrayList;
+import java.util.List;
 
 /**
- * <code>SerializableBatch</code> implements a serializable SPI Batch, which
+ * {@code SerializableBatch} implements a serializable SPI Batch, which
  * simply records all calls and replays them when asked for. The client of
  * this batch must ensure that the passed {@link QValue} instances are
- * serializable, otherwise the serializing the <code>Batch</code> will fail!
+ * serializable, otherwise the serializing the {@code Batch} will fail!
  */
 public class SerializableBatch implements Batch, Serializable {
 
-    private List<Operation> recording = new ArrayList<Operation>();
+    private final List<Operation> recording = new ArrayList<Operation>();
 
     private final ItemId itemId;
 
     /**
-     * Creates a new <code>SerializableBatch</code>.
+     * Creates a new {@code SerializableBatch}.
      *
      * @param itemId the id of the item where save was called. To indicate that
      *               save was called on the session, the id of the root node
@@ -68,12 +59,12 @@ public class SerializableBatch implement
     }
 
     /**
-     * Replays this batch on the given <code>batch</code>. For a description of
+     * Replays this batch on the given {@code batch}. For a description of
      * the exception see {@link org.apache.jackrabbit.spi.RepositoryService#submit(Batch)}.
      *
      * @param batch the target batch.
      */
-    public void replay(Batch batch) throws PathNotFoundException, ItemNotFoundException, NoSuchNodeTypeException, ValueFormatException, VersionException, LockException, ConstraintViolationException, AccessDeniedException, UnsupportedRepositoryOperationException, RepositoryException {
+    public void replay(Batch batch) throws RepositoryException {
         for (Operation operation : recording) {
             operation.replay(batch);
         }
@@ -81,50 +72,53 @@ public class SerializableBatch implement
 
     //----------------------------< Batch >-------------------------------------
 
-    public void addNode(NodeId parentId,
-                        Name nodeName,
-                        Name nodetypeName,
-                        String uuid) {
+    @Override
+    public void addNode(NodeId parentId, Name nodeName, Name nodetypeName, String uuid) {
         recording.add(new AddNode(parentId, nodeName, nodetypeName, uuid));
     }
 
+    @Override
     public void addProperty(NodeId parentId, Name propertyName, QValue value) {
         recording.add(new AddProperty(parentId, propertyName,
                 new QValue[]{value}, false));
     }
 
-    public void addProperty(NodeId parentId,
-                            Name propertyName,
-                            QValue[] values) {
+    @Override
+    public void addProperty(NodeId parentId, Name propertyName, QValue[] values) {
         recording.add(new AddProperty(parentId, propertyName, values, true));
     }
 
+    @Override
     public void setValue(PropertyId propertyId, QValue value) {
         recording.add(new SetValue(propertyId, new QValue[]{value}, false));
     }
 
+    @Override
     public void setValue(PropertyId propertyId, QValue[] values) {
         recording.add(new SetValue(propertyId, values, true));
     }
 
+    @Override
     public void remove(ItemId itemId) {
         recording.add(new Remove(itemId));
     }
 
-    public void reorderNodes(NodeId parentId,
-                             NodeId srcNodeId,
-                             NodeId beforeNodeId) {
+    @Override
+    public void reorderNodes(NodeId parentId, NodeId srcNodeId, NodeId beforeNodeId) {
         recording.add(new ReorderNodes(parentId, srcNodeId, beforeNodeId));
     }
 
+    @Override
     public void setMixins(NodeId nodeId, Name[] mixinNodeTypeIds) {
         recording.add(new SetMixins(nodeId, mixinNodeTypeIds));
     }
 
+    @Override
     public void setPrimaryType(NodeId nodeId, Name primaryNodeTypeName) throws RepositoryException {
         recording.add(new SetPrimaryType(nodeId, primaryNodeTypeName));
     }
 
+    @Override
     public void move(NodeId srcNodeId,
                      NodeId destParentNodeId,
                      Name destName) {
@@ -136,13 +130,13 @@ public class SerializableBatch implement
     public interface Operation extends Serializable {
 
         /**
-         * Replays this operation on the given <code>batch</code>.
+         * Replays this operation on the given {@code batch}.
          *
          * @param batch the batch.
          * @throws RepositoryException if an error occurs replaying the
          *                             operation.
          */
-        public void replay(Batch batch) throws RepositoryException;
+        void replay(Batch batch) throws RepositoryException;
     }
 
     private static class AddNode implements Operation {
@@ -162,9 +156,7 @@ public class SerializableBatch implement
             this.uuid = uuid;
         }
 
-        /**
-         * {@inheritDoc}
-         */
+        @Override
         public void replay(Batch batch) throws RepositoryException {
             batch.addNode(parentId, nodeName, nodetypeName, uuid);
         }
@@ -188,9 +180,7 @@ public class SerializableBatch implement
             this.isMultiValued = isMultiValued;
         }
 
-        /**
-         * {@inheritDoc}
-         */
+        @Override
         public void replay(Batch batch) throws RepositoryException {
             if (isMultiValued) {
                 batch.addProperty(parentId, propertyName, values);
@@ -214,9 +204,7 @@ public class SerializableBatch implement
             this.isMultiValued = isMultiValued;
         }
 
-        /**
-         * {@inheritDoc}
-         */
+        @Override
         public void replay(Batch batch) throws RepositoryException {
             if (isMultiValued) {
                 batch.setValue(propertyId, values);
@@ -234,9 +222,7 @@ public class SerializableBatch implement
             this.itemId = itemId;
         }
 
-        /**
-         * {@inheritDoc}
-         */
+        @Override
         public void replay(Batch batch) throws RepositoryException {
             batch.remove(itemId);
         }
@@ -256,9 +242,7 @@ public class SerializableBatch implement
             this.beforeNodeId = beforeNodeId;
         }
 
-        /**
-         * {@inheritDoc}
-         */
+        @Override
         public void replay(Batch batch) throws RepositoryException {
             batch.reorderNodes(parentId, srcNodeId, beforeNodeId);
         }
@@ -275,9 +259,7 @@ public class SerializableBatch implement
             this.mixinNodeTypeNames = mixinNodeTypeNames;
         }
 
-        /**
-         * {@inheritDoc}
-         */
+        @Override
         public void replay(Batch batch) throws RepositoryException {
             batch.setMixins(nodeId, mixinNodeTypeNames);
         }
@@ -294,9 +276,7 @@ public class SerializableBatch implement
             this.primaryNodeTypeName = primaryNodeTypeName;
         }
 
-        /**
-         * {@inheritDoc}
-         */
+        @Override
         public void replay(Batch batch) throws RepositoryException {
             batch.setPrimaryType(nodeId, primaryNodeTypeName);
         }
@@ -316,9 +296,7 @@ public class SerializableBatch implement
             this.destName = destName;
         }
 
-        /**
-         * {@inheritDoc}
-         */
+        @Override
         public void replay(Batch batch) throws RepositoryException {
             batch.move(srcNodeId, destParentNodeId, destName);
         }

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/SessionInfoImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/SessionInfoImpl.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/SessionInfoImpl.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/SessionInfoImpl.java Wed Sep  7 12:00:14 2011
@@ -24,23 +24,23 @@ import java.util.ArrayList;
 import java.util.List;
 
 /**
- * <code>SessionInfoImpl</code> is a serializable bean based implementation of
- * <code>SessionInfo</code>.
+ * {@code SessionInfoImpl} is a serializable bean based implementation of
+ * {@code SessionInfo}.
  */
 public class SessionInfoImpl implements SessionInfo, Serializable {
 
     /**
-     * The userId or <code>null</code> if unknown.
+     * The userId or {@code null} if unknown.
      */
     private String userId;
 
     /**
-     * The user data or <code>null</code>.
+     * The user data or {@code null}.
      */
     private String userData;
 
     /**
-     * The name of the workspace to connect to or <code>null</code> if this
+     * The name of the workspace to connect to or {@code null} if this
      * session info refers to the default workspace.
      */
     private String workspaceName;
@@ -48,18 +48,12 @@ public class SessionInfoImpl implements 
     /**
      * The list of lock tokens.
      */
-    private List<String> lockTokens = new ArrayList<String>();
-
-    /**
-     * Default constructor
-     */
-    public SessionInfoImpl() {
-    }
+    private final List<String> lockTokens = new ArrayList<String>();
 
     /**
      * Sets the userId.
      *
-     * @param userId the userId or <code>null</code> if unknown.
+     * @param userId the userId or {@code null} if unknown.
      */
     public void setUserID(String userId) {
         this.userId = userId;
@@ -68,7 +62,7 @@ public class SessionInfoImpl implements 
     /**
      * Sets the name of the workspace to connect to.
      *
-     * @param workspaceName the name of the workspace or <code>null</code> if
+     * @param workspaceName the name of the workspace or {@code null} if
      *                      this session info refers to the default workspace.
      */
     public void setWorkspacename(String workspaceName) {
@@ -77,44 +71,32 @@ public class SessionInfoImpl implements 
 
     //-------------------------< SessionInfo >----------------------------------
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public String getUserID() {
         return userId;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public String getWorkspaceName() {
         return workspaceName;
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public String[] getLockTokens() {
         return lockTokens.toArray(new String[lockTokens.size()]);
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public void addLockToken(String s) {
         lockTokens.add(s);
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public void removeLockToken(String s) {
         lockTokens.remove(s);
     }
 
-    /**
-     * {@inheritDoc}
-     */
+    @Override
     public void setUserData(String userData) throws RepositoryException {
         this.userData = userData;
     }

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/batch/AbstractChangeLog.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/batch/AbstractChangeLog.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/batch/AbstractChangeLog.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/batch/AbstractChangeLog.java Wed Sep  7 12:00:14 2011
@@ -16,17 +16,16 @@
  */
 package org.apache.jackrabbit.spi.commons.batch;
 
+import org.apache.jackrabbit.spi.Batch;
+
+import javax.jcr.RepositoryException;
 import java.util.Iterator;
 import java.util.LinkedList;
 import java.util.List;
 
-import javax.jcr.RepositoryException;
-
-import org.apache.jackrabbit.spi.Batch;
-
 /**
  * This base class for {@link ChangeLog} implementations maintains a list of operations
- * of type type <code>T</code>.
+ * of type type {@code T}.
  * @param <T>
  */
 public abstract class AbstractChangeLog<T extends Operation> implements ChangeLog {
@@ -47,15 +46,15 @@ public abstract class AbstractChangeLog<
 
     /**
      * This implementation applies each of the operation maintained by
-     * this change log to the passed <code>batch</code>.
+     * this change log to the passed {@code batch}.
      * {@inheritDoc}
      */
+    @Override
     public Batch apply(Batch batch) throws RepositoryException {
         if (batch == null) {
             throw new IllegalArgumentException("Batch must not be null");
         }
-        for (Iterator<T> it = operations.iterator(); it.hasNext(); ) {
-            Operation op = it.next();
+        for (T op : operations) {
             op.apply(batch);
         }
         return batch;
@@ -63,7 +62,7 @@ public abstract class AbstractChangeLog<
 
     @Override
     public String toString() {
-        StringBuffer b = new StringBuffer();
+        StringBuilder b = new StringBuilder();
         for (Iterator<T> it = operations.iterator(); it.hasNext(); ) {
             b.append(it.next());
             if (it.hasNext()) {

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/batch/ChangeLog.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/batch/ChangeLog.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/batch/ChangeLog.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/batch/ChangeLog.java Wed Sep  7 12:00:14 2011
@@ -16,13 +16,13 @@
  */
 package org.apache.jackrabbit.spi.commons.batch;
 
-import javax.jcr.RepositoryException;
-
 import org.apache.jackrabbit.spi.Batch;
 
+import javax.jcr.RepositoryException;
+
 
 /**
- * A <code>ChangeLog</code> is a specialized {@link Batch} which
+ * A {@code ChangeLog} is a specialized {@link Batch} which
  * keeps a list of {@link Operation}s. The {@link #apply(Batch)} method
  * applies these operations to another batch.
  */
@@ -30,11 +30,11 @@ public interface ChangeLog extends Batch
 
     /**
      * Applies the {@link Operation}s contained in this change log to
-     * the passed <code>batch</code>.
+     * the passed {@code batch}.
      * @param batch
-     * @return  The <code>batch</code> passed in as argument with the
+     * @return The {@code batch} passed in as argument with the
      *   operations from this change log applied.
      * @throws RepositoryException
      */
-    public Batch apply(Batch batch) throws RepositoryException;
+    Batch apply(Batch batch) throws RepositoryException;
 }

Modified: jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/batch/ChangeLogImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/batch/ChangeLogImpl.java?rev=1166138&r1=1166137&r2=1166138&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/batch/ChangeLogImpl.java (original)
+++ jackrabbit/sandbox/jackrabbit-mk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/batch/ChangeLogImpl.java Wed Sep  7 12:00:14 2011
@@ -17,8 +17,6 @@
 package org.apache.jackrabbit.spi.commons.batch;
 
 
-import javax.jcr.RepositoryException;
-
 import org.apache.jackrabbit.spi.Batch;
 import org.apache.jackrabbit.spi.ItemId;
 import org.apache.jackrabbit.spi.Name;
@@ -26,6 +24,8 @@ import org.apache.jackrabbit.spi.NodeId;
 import org.apache.jackrabbit.spi.PropertyId;
 import org.apache.jackrabbit.spi.QValue;
 
+import javax.jcr.RepositoryException;
+
 /**
  * This {@link ChangeLog} implementation simply keeps back all calls to its {@link Batch} methods as
  * a list of {@link #operations} (with item of type {@link Operation}). When {@link #apply(Batch)
@@ -34,48 +34,56 @@ import org.apache.jackrabbit.spi.QValue;
  */
 public class ChangeLogImpl extends AbstractChangeLog<Operation> {
 
-    public void addNode(NodeId parentId, Name nodeName, Name nodetypeName, String uuid)
-            throws RepositoryException {
-
+    @Override
+    public void addNode(NodeId parentId, Name nodeName, Name nodetypeName, String uuid) throws RepositoryException {
         addOperation(Operations.addNode(parentId, nodeName, nodetypeName, uuid));
     }
 
+    @Override
     public void addProperty(NodeId parentId, Name propertyName, QValue value) throws RepositoryException {
         addOperation(Operations.addProperty(parentId, propertyName, value));
     }
 
+    @Override
     public void addProperty(NodeId parentId, Name propertyName, QValue[] values)
             throws RepositoryException {
 
         addOperation(Operations.addProperty(parentId, propertyName, values));
     }
 
+    @Override
     public void move(NodeId srcNodeId, NodeId destParentNodeId, Name destName) throws RepositoryException {
         addOperation(Operations.move(srcNodeId, destParentNodeId, destName));
     }
 
+    @Override
     public void remove(ItemId itemId) throws RepositoryException {
         addOperation(Operations.remove(itemId));
     }
 
+    @Override
     public void reorderNodes(NodeId parentId, NodeId srcNodeId, NodeId beforeNodeId)
             throws RepositoryException {
 
         addOperation(Operations.reorderNodes(parentId, srcNodeId, beforeNodeId));
     }
 
+    @Override
     public void setMixins(NodeId nodeId, Name[] mixinNodeTypeNames) throws RepositoryException {
         addOperation(Operations.setMixins(nodeId, mixinNodeTypeNames));
     }
 
+    @Override
     public void setPrimaryType(NodeId nodeId, Name primaryNodeTypeName) throws RepositoryException {
         addOperation(Operations.setPrimaryType(nodeId, primaryNodeTypeName));
     }
 
+    @Override
     public void setValue(PropertyId propertyId, QValue value) throws RepositoryException {
         addOperation(Operations.setValue(propertyId, value));
     }
 
+    @Override
     public void setValue(PropertyId propertyId, QValue[] values) throws RepositoryException {
         addOperation(Operations.setValue(propertyId, values));
     }



Mime
View raw message