From commits-return-11471-apmail-jackrabbit-commits-archive=jackrabbit.apache.org@jackrabbit.apache.org Wed Jul 13 16:48:19 2011 Return-Path: X-Original-To: apmail-jackrabbit-commits-archive@www.apache.org Delivered-To: apmail-jackrabbit-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B1E9B6482 for ; Wed, 13 Jul 2011 16:48:19 +0000 (UTC) Received: (qmail 27004 invoked by uid 500); 13 Jul 2011 16:48:19 -0000 Delivered-To: apmail-jackrabbit-commits-archive@jackrabbit.apache.org Received: (qmail 26957 invoked by uid 500); 13 Jul 2011 16:48:18 -0000 Mailing-List: contact commits-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list commits@jackrabbit.apache.org Received: (qmail 26950 invoked by uid 99); 13 Jul 2011 16:48:18 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jul 2011 16:48:18 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jul 2011 16:48:16 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 0214A2388894; Wed, 13 Jul 2011 16:47:55 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1146125 - in /jackrabbit/trunk/jackrabbit-core/src: main/java/org/apache/jackrabbit/core/session/SessionItemOperation.java test/java/org/apache/jackrabbit/core/integration/SessionImplTest.java Date: Wed, 13 Jul 2011 16:47:54 -0000 To: commits@jackrabbit.apache.org From: alexparvulescu@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110713164755.0214A2388894@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: alexparvulescu Date: Wed Jul 13 16:47:54 2011 New Revision: 1146125 URL: http://svn.apache.org/viewvc?rev=1146125&view=rev Log: JCR-3014 Identifier paths for inexistent items throw exception - full rollback Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/session/SessionItemOperation.java jackrabbit/trunk/jackrabbit-core/src/test/java/org/apache/jackrabbit/core/integration/SessionImplTest.java Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/session/SessionItemOperation.java URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/session/SessionItemOperation.java?rev=1146125&r1=1146124&r2=1146125&view=diff ============================================================================== --- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/session/SessionItemOperation.java (original) +++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/session/SessionItemOperation.java Wed Jul 13 16:47:54 2011 @@ -48,14 +48,6 @@ public abstract class SessionItemOperati protected Boolean perform(ItemManager manager, Path path) { return manager.itemExists(path); } - @Override - public Boolean perform(SessionContext context) { - try { - return super.perform(context); - } catch (RepositoryException e) { - return false; - } - } }; } @@ -88,14 +80,6 @@ public abstract class SessionItemOperati protected Boolean perform(ItemManager manager, Path path) { return manager.nodeExists(path); } - @Override - public Boolean perform(SessionContext context) { - try { - return super.perform(context); - } catch (RepositoryException e) { - return false; - } - } }; } Modified: jackrabbit/trunk/jackrabbit-core/src/test/java/org/apache/jackrabbit/core/integration/SessionImplTest.java URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/test/java/org/apache/jackrabbit/core/integration/SessionImplTest.java?rev=1146125&r1=1146124&r2=1146125&view=diff ============================================================================== --- jackrabbit/trunk/jackrabbit-core/src/test/java/org/apache/jackrabbit/core/integration/SessionImplTest.java (original) +++ jackrabbit/trunk/jackrabbit-core/src/test/java/org/apache/jackrabbit/core/integration/SessionImplTest.java Wed Jul 13 16:47:54 2011 @@ -27,7 +27,6 @@ import javax.security.auth.Subject; import org.apache.jackrabbit.core.RepositoryImpl; import org.apache.jackrabbit.core.SessionImpl; -import org.apache.jackrabbit.core.id.NodeId; import org.apache.jackrabbit.core.security.principal.PrincipalImpl; import org.apache.jackrabbit.test.AbstractJCRTest; import org.apache.jackrabbit.test.NotExecutableException; @@ -163,16 +162,4 @@ public class SessionImplTest extends Abs // success } } - - /** - * JCR-3014 Identifier paths for inexistent items throw exception - * - * @see JCR-3014 - */ - public void testCheckNonExistingItem() throws Exception { - String dummyPath = "[" + NodeId.randomId() + "]"; - assertFalse(superuser.itemExists(dummyPath)); - assertFalse(superuser.nodeExists(dummyPath)); - } }