jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thom...@apache.org
Subject svn commit: r1135643 - in /jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk: MicroKernelImpl.java api/MicroKernel.java
Date Tue, 14 Jun 2011 15:21:48 GMT
Author: thomasm
Date: Tue Jun 14 15:21:48 2011
New Revision: 1135643

URL: http://svn.apache.org/viewvc?rev=1135643&view=rev
Log:
Fix Json returned by getChildNodes(..)

Modified:
    jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/MicroKernelImpl.java
    jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java

Modified: jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/MicroKernelImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/MicroKernelImpl.java?rev=1135643&r1=1135642&r2=1135643&view=diff
==============================================================================
--- jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/MicroKernelImpl.java
(original)
+++ jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/MicroKernelImpl.java
Tue Jun 14 15:21:48 2011
@@ -244,7 +244,7 @@ public class MicroKernelImpl implements 
                 if (pos - offset >= count) {
                     break;
                 }
-                toJson(rep.getStore().getNode(entry.getValue()), entry.getKey(), depth, true,
buf);
+                buf.value(entry.getKey());
                 pos++;
             }
             return buf.endArray().toString();

Modified: jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java?rev=1135643&r1=1135642&r2=1135643&view=diff
==============================================================================
--- jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java
(original)
+++ jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/api/MicroKernel.java
Tue Jun 14 15:21:48 2011
@@ -249,6 +249,8 @@ public interface MicroKernel {
      * @return array of node tree in JSON format
      * @throws MicroKernelException if an error occurs
      */
+    // TODO depth: does it even make sense in this context?
+    // if depth is needed, why not use getNodes?
     String /* array of jsonTrees */ getChildNodes(String path, long offset, long count, int
depth, String revisionId) throws MicroKernelException;
 
     /**
@@ -261,6 +263,9 @@ public interface MicroKernel {
      * @return number of child nodes
      * @throws MicroKernelException if an error occurs
      */
+    // TODO is it required? might as well use getNodes(path) with depth 0
+    // except that parsing isn't required here
+    // (but parsing is required when calling getChildNodes anyway)
     long /* count */ getChildNodeCount(String path, String revisionId)
             throws MicroKernelException;
 



Mime
View raw message