jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ang...@apache.org
Subject svn commit: r1104042 - in /jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav: ./ security/ security/report/
Date Tue, 17 May 2011 07:52:40 GMT
Author: angela
Date: Tue May 17 07:52:40 2011
New Revision: 1104042

URL: http://svn.apache.org/viewvc?rev=1104042&view=rev
Log:
minor improvement

Modified:
    jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/DavResourceIteratorImpl.java
    jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/Status.java
    jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/AclProperty.java
    jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/report/PrincipalMatchReport.java
    jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/report/SearchablePropertyReport.java

Modified: jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/DavResourceIteratorImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/DavResourceIteratorImpl.java?rev=1104042&r1=1104041&r2=1104042&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/DavResourceIteratorImpl.java
(original)
+++ jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/DavResourceIteratorImpl.java
Tue May 17 07:52:40 2011
@@ -32,7 +32,7 @@ public class DavResourceIteratorImpl imp
 
     private static Logger log = LoggerFactory.getLogger(DavResourceIteratorImpl.class);
 
-    public static DavResourceIterator EMPTY = new DavResourceIteratorImpl(Collections.<DavResource>emptyList());
+    public static final DavResourceIterator EMPTY = new DavResourceIteratorImpl(Collections.<DavResource>emptyList());
 
     private Iterator<DavResource> it;
     private int size;

Modified: jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/Status.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/Status.java?rev=1104042&r1=1104041&r2=1104042&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/Status.java
(original)
+++ jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/Status.java
Tue May 17 07:52:40 2011
@@ -86,7 +86,7 @@ public class Status implements DavConsta
                 log.warn("Status-Line '" + statusLine + "' does not start with HTTP");
             }
             //handle the HTTP-Version
-            at = statusLine.indexOf(" ", at);
+            at = statusLine.indexOf(' ', at);
             if (at <= 0) {
                 log.warn("Unable to parse HTTP-Version from the status line: '" + statusLine
+ "'");
             }
@@ -97,7 +97,7 @@ public class Status implements DavConsta
             }
             //handle the Status-Code
             int code;
-            int to = statusLine.indexOf(" ", at);
+            int to = statusLine.indexOf(' ', at);
             if (to < 0) {
                 to = length;
             }

Modified: jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/AclProperty.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/AclProperty.java?rev=1104042&r1=1104041&r2=1104042&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/AclProperty.java
(original)
+++ jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/AclProperty.java
Tue May 17 07:52:40 2011
@@ -256,8 +256,7 @@ public class AclProperty extends Abstrac
                 inheritedHref = DomUtil.getChildText(inhE, DavConstants.XML_HREF, DavConstants.NAMESPACE);
             }
 
-            Ace ace = new Ace(principal, invert, privileges, grant,  isProtected, inheritedHref);
-            return ace;
+            return new Ace(principal, invert, privileges, grant,  isProtected, inheritedHref);
         }
     }
 }

Modified: jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/report/PrincipalMatchReport.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/report/PrincipalMatchReport.java?rev=1104042&r1=1104041&r2=1104042&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/report/PrincipalMatchReport.java
(original)
+++ jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/report/PrincipalMatchReport.java
Tue May 17 07:52:40 2011
@@ -51,8 +51,8 @@ import org.w3c.dom.Element;
  */
 public class PrincipalMatchReport extends AbstractSecurityReport {
 
-    public static String XML_PRINCIPAL_PROPERTY = "principal-property";
-    public static String XML_SELF = "self";
+    public static final String XML_PRINCIPAL_PROPERTY = "principal-property";
+    public static final String XML_SELF = "self";
 
     /**
      * The report name

Modified: jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/report/SearchablePropertyReport.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/report/SearchablePropertyReport.java?rev=1104042&r1=1104041&r2=1104042&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/report/SearchablePropertyReport.java
(original)
+++ jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/security/report/SearchablePropertyReport.java
Tue May 17 07:52:40 2011
@@ -77,7 +77,7 @@ public class SearchablePropertyReport im
     /**
      * Set collecting the DAV:principal-search-property entries.
      */
-    public final Set<PrincipalSearchProperty> searchPropertySet = new HashSet<PrincipalSearchProperty>();
+    private final Set<PrincipalSearchProperty> searchPropertySet = new HashSet<PrincipalSearchProperty>();
 
     /**
      * @see Report#getType()



Mime
View raw message