jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mreut...@apache.org
Subject svn commit: r809524 - /jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/query/sql2/Parser.java
Date Mon, 31 Aug 2009 09:40:11 GMT
Author: mreutegg
Date: Mon Aug 31 09:40:11 2009
New Revision: 809524

URL: http://svn.apache.org/viewvc?rev=809524&view=rev
Log:
JCR-2282: SQL2 parser must not infer type for UncastLiteral from static analysis

Modified:
    jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/query/sql2/Parser.java

Modified: jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/query/sql2/Parser.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/query/sql2/Parser.java?rev=809524&r1=809523&r2=809524&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/query/sql2/Parser.java
(original)
+++ jackrabbit/trunk/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/query/sql2/Parser.java
Mon Aug 31 09:40:11 2009
@@ -496,7 +496,7 @@
     }
 
     /**
-     * Create a literal from a parsed value. This method is (currently) not spec compliant.
+     * Create a literal from a parsed value.
      *
      * @param value the original value
      * @return the literal
@@ -505,19 +505,6 @@
         return factory.literal(value);
     }
 
-    /**
-     * Create uncast literal from a value. According to the JCR specification,
-     * "an UncastLiteral is always interpreted as a Value of property type STRING"
-     * (JCR 2.0 Core Specification, 6.7.34 Literal, page 124).
-     * That means the value is converted to a String first.
-     *
-     * @param value the original value
-     * @return the literal
-     */
-    private Literal getUncastLiteralSpecCompliant(Value value) throws RepositoryException
{
-        return factory.literal(valueFactory.createValue(value.getString()));
-    }
-
     private Value parseCastAs(Value value) throws RepositoryException {
         if (readIf("STRING")) {
             return valueFactory.createValue(value.getString());



Mime
View raw message