jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From resc...@apache.org
Subject svn commit: r792168 - in /jackrabbit/trunk: jackrabbit-core/pom.xml jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/NodeReadMethodsTest.java jackrabbit-spi2jcr/pom.xml
Date Wed, 08 Jul 2009 14:44:16 GMT
Author: reschke
Date: Wed Jul  8 14:44:16 2009
New Revision: 792168

URL: http://svn.apache.org/viewvc?rev=792168&view=rev
Log:
JCR-2060: fix tests that used a pattern where only a glob was allowed

Modified:
    jackrabbit/trunk/jackrabbit-core/pom.xml
    jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/NodeReadMethodsTest.java
    jackrabbit/trunk/jackrabbit-spi2jcr/pom.xml

Modified: jackrabbit/trunk/jackrabbit-core/pom.xml
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/pom.xml?rev=792168&r1=792167&r2=792168&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-core/pom.xml (original)
+++ jackrabbit/trunk/jackrabbit-core/pom.xml Wed Jul  8 14:44:16 2009
@@ -91,7 +91,6 @@
               <name>known.issues</name>
               <value>
                 org.apache.jackrabbit.core.xml.DocumentViewTest#testMultiValue
-                org.apache.jackrabbit.test.api.NodeReadMethodsTest#testGetPropertiesNamePatternArray
                 org.apache.jackrabbit.test.api.version.ActivitiesTest#testActivitiesPath
                 org.apache.jackrabbit.test.api.nodetype.NodeTypeCreationTest#testPropertyDefinitionTemplate
               </value>

Modified: jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/NodeReadMethodsTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/NodeReadMethodsTest.java?rev=792168&r1=792167&r2=792168&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/NodeReadMethodsTest.java
(original)
+++ jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/NodeReadMethodsTest.java
Wed Jul  8 14:44:16 2009
@@ -501,31 +501,6 @@
                 numExpected2,
                 getSize(nodes2));
 
-
-        // test pattern "nodeName|nodeName"
-        String pattern3 = firstNode.getName() + "|" + firstNode.getName();
-        String assertString3 = "node.getNodes(\"" + pattern3 + "\"): ";
-        // test if the names of the found nodes are matching the pattern
-        NodeIterator nodes3 = node.getNodes(pattern3);
-        while (nodes3.hasNext()) {
-            Node n = nodes3.nextNode();
-            assertEquals(assertString2 + "name comparison failed: ",
-                    firstNode.getName(),
-                    n.getName());
-        }
-        // test if the number of found nodes is correct
-        int numExpected3 = 0;
-        for (int i = 0; i < allNodes.size(); i++) {
-            Node n = (Node) allNodes.get(i);
-            if (n.getName().equals(firstNode.getName())) {
-                numExpected3++;
-            }
-        }
-        assertEquals(assertString3 + "number of nodes found: ",
-                numExpected3,
-                getSize(nodes3));
-
-
         // test pattern "nodeName", "nodeName"
         String pattern4 = firstNode.getName() + "," + firstNode.getName();
         String assertString4 = "node.getNodes(\"" + pattern4 + "\"): ";
@@ -801,30 +776,7 @@
                 numExpected2,
                 getSize(properties2));
 
-
         // test: getProperties("propertyName|propertyName")
-        String pattern3 = firstProperty.getName() + "|" + firstProperty.getName();
-        String assertString3 = "node.getProperties(\"" + pattern3 + "\"): ";
-        // test if the names of the found properties are matching the pattern
-        PropertyIterator properties3 = node.getProperties(new String[] { pattern3 });
-        while (properties3.hasNext()) {
-            Property p = properties3.nextProperty();
-            assertEquals(assertString2 + "name comparison failed: ",
-                    firstProperty.getName(),
-                    p.getName());
-        }
-        // test if the number of found properties is correct
-        int numExpected3 = 0;
-        for (int i = 0; i < allProperties.size(); i++) {
-            Property p = (Property) allProperties.get(i);
-            if (p.getName().equals(firstProperty.getName())) {
-                numExpected3++;
-            }
-        }
-        assertEquals(assertString3 + "number of properties found: ",
-                numExpected3,
-                getSize(properties3));
-
         // test: getProperties("propertyName", "propertyName")
         String pattern4 = firstProperty.getName() + "," + firstProperty.getName();
         String assertString4 = "node.getProperties(\"" + pattern4 + "\"): ";

Modified: jackrabbit/trunk/jackrabbit-spi2jcr/pom.xml
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-spi2jcr/pom.xml?rev=792168&r1=792167&r2=792168&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-spi2jcr/pom.xml (original)
+++ jackrabbit/trunk/jackrabbit-spi2jcr/pom.xml Wed Jul  8 14:44:16 2009
@@ -71,7 +71,6 @@
                 org.apache.jackrabbit.jcr2spi.name.NamespaceRegistryTest#testRegisteredNamespaceVisibility
                 org.apache.jackrabbit.test.api.ShareableNodeTest
                 org.apache.jackrabbit.test.api.version.simple
-                org.apache.jackrabbit.test.api.NodeReadMethodsTest#testGetPropertiesNamePatternArray
                 org.apache.jackrabbit.test.api.version.ActivitiesTest
                 org.apache.jackrabbit.test.api.nodetype.NodeTypeCreationTest#testPropertyDefinitionTemplate
               </value>



Mime
View raw message