Return-Path: Delivered-To: apmail-jackrabbit-commits-archive@www.apache.org Received: (qmail 34829 invoked from network); 17 Mar 2008 15:44:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Mar 2008 15:44:13 -0000 Received: (qmail 25257 invoked by uid 500); 17 Mar 2008 15:44:10 -0000 Delivered-To: apmail-jackrabbit-commits-archive@jackrabbit.apache.org Received: (qmail 25224 invoked by uid 500); 17 Mar 2008 15:44:10 -0000 Mailing-List: contact commits-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list commits@jackrabbit.apache.org Received: (qmail 25215 invoked by uid 99); 17 Mar 2008 15:44:10 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Mar 2008 08:44:10 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Mar 2008 15:43:30 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id F1AC61A983A; Mon, 17 Mar 2008 08:43:49 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r637946 - in /jackrabbit/trunk/jackrabbit-core/src: main/java/org/apache/jackrabbit/core/version/InternalVersionHistoryImpl.java test/java/org/apache/jackrabbit/core/version/RemoveVersionLabelTest.java Date: Mon, 17 Mar 2008 15:43:49 -0000 To: commits@jackrabbit.apache.org From: mreutegg@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080317154349.F1AC61A983A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: mreutegg Date: Mon Mar 17 08:43:48 2008 New Revision: 637946 URL: http://svn.apache.org/viewvc?rev=637946&view=rev Log: JCR-1475: Inconsistency when version with a label is removed Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/version/InternalVersionHistoryImpl.java jackrabbit/trunk/jackrabbit-core/src/test/java/org/apache/jackrabbit/core/version/RemoveVersionLabelTest.java Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/version/InternalVersionHistoryImpl.java URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/version/InternalVersionHistoryImpl.java?rev=637946&r1=637945&r2=637946&view=diff ============================================================================== --- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/version/InternalVersionHistoryImpl.java (original) +++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/version/InternalVersionHistoryImpl.java Mon Mar 17 08:43:48 2008 @@ -385,6 +385,11 @@ // store changes node.store(); + + // now also remove from labelCache + for (int i = 0; i < labels.length; i++) { + labelCache.remove(labels[i]); + } } /** Modified: jackrabbit/trunk/jackrabbit-core/src/test/java/org/apache/jackrabbit/core/version/RemoveVersionLabelTest.java URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/test/java/org/apache/jackrabbit/core/version/RemoveVersionLabelTest.java?rev=637946&r1=637945&r2=637946&view=diff ============================================================================== --- jackrabbit/trunk/jackrabbit-core/src/test/java/org/apache/jackrabbit/core/version/RemoveVersionLabelTest.java (original) +++ jackrabbit/trunk/jackrabbit-core/src/test/java/org/apache/jackrabbit/core/version/RemoveVersionLabelTest.java Mon Mar 17 08:43:48 2008 @@ -37,13 +37,10 @@ n.checkin(); VersionHistory vh = n.getVersionHistory(); vh.addVersionLabel(v10.getName(), "test", true); - // either the next call should fail + // the next call must not fail vh.removeVersion(v10.getName()); - // or the label 'test' should be gone + // now the label must be gone String[] labels = vh.getVersionLabels(); - for (int i = 0; i < labels.length; i++) { - // and this is never called - vh.removeVersionLabel(labels[i]); - } + assertEquals("Label of a removed version must be removed as well", 0, labels.length); } }