jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clomb...@apache.org
Subject svn commit: r594286 - in /jackrabbit/sandbox/jackrabbit-jcr-mapping/jcr-mapping/src/test/java/org/apache/jackrabbit/ocm/security: SimpleAccessManager.java SimpleLoginModule.java
Date Mon, 12 Nov 2007 20:18:34 GMT
Author: clombart
Date: Mon Nov 12 12:18:33 2007
New Revision: 594286

URL: http://svn.apache.org/viewvc?rev=594286&view=rev
Log:
Patch for JCR-1199 provided by Carsten. Thanks

Modified:
    jackrabbit/sandbox/jackrabbit-jcr-mapping/jcr-mapping/src/test/java/org/apache/jackrabbit/ocm/security/SimpleAccessManager.java
    jackrabbit/sandbox/jackrabbit-jcr-mapping/jcr-mapping/src/test/java/org/apache/jackrabbit/ocm/security/SimpleLoginModule.java

Modified: jackrabbit/sandbox/jackrabbit-jcr-mapping/jcr-mapping/src/test/java/org/apache/jackrabbit/ocm/security/SimpleAccessManager.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-jcr-mapping/jcr-mapping/src/test/java/org/apache/jackrabbit/ocm/security/SimpleAccessManager.java?rev=594286&r1=594285&r2=594286&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-jcr-mapping/jcr-mapping/src/test/java/org/apache/jackrabbit/ocm/security/SimpleAccessManager.java
(original)
+++ jackrabbit/sandbox/jackrabbit-jcr-mapping/jcr-mapping/src/test/java/org/apache/jackrabbit/ocm/security/SimpleAccessManager.java
Mon Nov 12 12:18:33 2007
@@ -28,7 +28,7 @@
 import org.apache.jackrabbit.core.security.AccessManager;
 import org.apache.jackrabbit.core.security.AnonymousPrincipal;
 import org.apache.jackrabbit.core.security.SystemPrincipal;
-import org.apache.log4j.Logger;
+
 
 /**
  * <code>SimpleAccessManager</code> ...
@@ -36,8 +36,6 @@
 public class SimpleAccessManager implements AccessManager
 {
 
-	private static Logger log = Logger.getLogger(SimpleAccessManager.class);
-
 	/**
 	 * Subject whose access rights this AccessManager should reflect
 	 */
@@ -149,8 +147,8 @@
 
 		// @todo check permission based on principals
 		return true;
-	
-		
+
+
 	}
 
 	/**

Modified: jackrabbit/sandbox/jackrabbit-jcr-mapping/jcr-mapping/src/test/java/org/apache/jackrabbit/ocm/security/SimpleLoginModule.java
URL: http://svn.apache.org/viewvc/jackrabbit/sandbox/jackrabbit-jcr-mapping/jcr-mapping/src/test/java/org/apache/jackrabbit/ocm/security/SimpleLoginModule.java?rev=594286&r1=594285&r2=594286&view=diff
==============================================================================
--- jackrabbit/sandbox/jackrabbit-jcr-mapping/jcr-mapping/src/test/java/org/apache/jackrabbit/ocm/security/SimpleLoginModule.java
(original)
+++ jackrabbit/sandbox/jackrabbit-jcr-mapping/jcr-mapping/src/test/java/org/apache/jackrabbit/ocm/security/SimpleLoginModule.java
Mon Nov 12 12:18:33 2007
@@ -34,7 +34,6 @@
 import org.apache.jackrabbit.core.security.CredentialsCallback;
 import org.apache.jackrabbit.core.security.SecurityConstants;
 import org.apache.jackrabbit.core.security.UserPrincipal;
-import org.apache.log4j.Logger;
 
 /**
  * A <code>SimpleLoginModule</code> ...
@@ -42,8 +41,6 @@
 public class SimpleLoginModule implements LoginModule
 {
 
-	private static Logger log = Logger.getLogger(SimpleLoginModule.class);
-
 	/**
 	 * Name of the anonymous user id option in the LoginModule configuration
 	 */
@@ -134,8 +131,6 @@
 					Object attr = sc.getAttribute(SecurityConstants.IMPERSONATOR_ATTRIBUTE);
 					if (attr != null && attr instanceof Subject)
 					{
-						Subject impersonator = (Subject) attr;
-						// @todo check privileges to 'impersonate' the user represented by the supplied credentials
 					}
 					else
 					{



Mime
View raw message