Return-Path: Delivered-To: apmail-jackrabbit-commits-archive@www.apache.org Received: (qmail 87844 invoked from network); 3 Jan 2007 17:43:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Jan 2007 17:43:43 -0000 Received: (qmail 23759 invoked by uid 500); 3 Jan 2007 17:43:49 -0000 Delivered-To: apmail-jackrabbit-commits-archive@jackrabbit.apache.org Received: (qmail 23735 invoked by uid 500); 3 Jan 2007 17:43:49 -0000 Mailing-List: contact commits-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list commits@jackrabbit.apache.org Received: (qmail 23726 invoked by uid 99); 3 Jan 2007 17:43:49 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 09:43:49 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 09:43:42 -0800 Received: by eris.apache.org (Postfix, from userid 65534) id B97E31A981A; Wed, 3 Jan 2007 09:42:45 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r492235 - /jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java Date: Wed, 03 Jan 2007 17:42:45 -0000 To: commits@jackrabbit.apache.org From: mreutegg@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20070103174245.B97E31A981A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: mreutegg Date: Wed Jan 3 09:42:44 2007 New Revision: 492235 URL: http://svn.apache.org/viewvc?view=rev&rev=492235 Log: JCR-689: Minimize calls to PersistenceManager Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java?view=diff&rev=492235&r1=492234&r2=492235 ============================================================================== --- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java (original) +++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/NodeImpl.java Wed Jan 3 09:42:44 2007 @@ -421,6 +421,17 @@ throws ConstraintViolationException, RepositoryException { status.clear(); + if (isNew() && !hasProperty(name)) { + // this is a new node and the property does not exist yet + // -> no need to check item manager + PropertyDefinitionImpl def = getApplicablePropertyDefinition( + name, type, multiValued, exactTypeMatch); + PropertyImpl prop = createChildProperty(name, type, def); + status.set(CREATED); + return prop; + } + + /* * Please note, that this implementation does not win a price for beauty * or speed. It's never a good idea to use exceptions for semantical