From commits-return-2908-apmail-jackrabbit-commits-archive=jackrabbit.apache.org@jackrabbit.apache.org Wed Oct 04 06:46:23 2006 Return-Path: Delivered-To: apmail-jackrabbit-commits-archive@www.apache.org Received: (qmail 85404 invoked from network); 4 Oct 2006 06:46:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 4 Oct 2006 06:46:23 -0000 Received: (qmail 69980 invoked by uid 500); 4 Oct 2006 06:46:23 -0000 Delivered-To: apmail-jackrabbit-commits-archive@jackrabbit.apache.org Received: (qmail 69887 invoked by uid 500); 4 Oct 2006 06:46:22 -0000 Mailing-List: contact commits-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list commits@jackrabbit.apache.org Received: (qmail 69878 invoked by uid 99); 4 Oct 2006 06:46:22 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Oct 2006 23:46:22 -0700 X-ASF-Spam-Status: No, hits=-9.4 required=5.0 tests=ALL_TRUSTED,NO_REAL_NAME Received: from [140.211.166.113] ([140.211.166.113:63679] helo=eris.apache.org) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id 23/5F-00170-CB853254 for ; Tue, 03 Oct 2006 23:46:20 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id BA5291A981A; Tue, 3 Oct 2006 23:46:08 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r452765 - /jackrabbit/trunk/jcr-server/webdav/src/java/org/apache/jackrabbit/webdav/version/report/ReportType.java Date: Wed, 04 Oct 2006 06:46:08 -0000 To: commits@jackrabbit.apache.org From: angela@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20061004064608.BA5291A981A@eris.apache.org> X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: angela Date: Tue Oct 3 23:46:08 2006 New Revision: 452765 URL: http://svn.apache.org/viewvc?view=rev&rev=452765 Log: - wrong status code, if Report.init fails. - misleading message if creating report instance from class fails Modified: jackrabbit/trunk/jcr-server/webdav/src/java/org/apache/jackrabbit/webdav/version/report/ReportType.java Modified: jackrabbit/trunk/jcr-server/webdav/src/java/org/apache/jackrabbit/webdav/version/report/ReportType.java URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jcr-server/webdav/src/java/org/apache/jackrabbit/webdav/version/report/ReportType.java?view=diff&rev=452765&r1=452764&r2=452765 ============================================================================== --- jackrabbit/trunk/jcr-server/webdav/src/java/org/apache/jackrabbit/webdav/version/report/ReportType.java (original) +++ jackrabbit/trunk/jcr-server/webdav/src/java/org/apache/jackrabbit/webdav/version/report/ReportType.java Tue Oct 3 23:46:08 2006 @@ -71,9 +71,12 @@ Report report = (Report) reportClass.newInstance(); report.init(resource, info); return report; - } catch (Exception e) { + } catch (IllegalAccessException e) { // should never occur - throw new DavException(DavServletResponse.SC_INTERNAL_SERVER_ERROR, "Failed to register Report."); + throw new DavException(DavServletResponse.SC_INTERNAL_SERVER_ERROR, "Failed to create new report (" + reportClass.getName() + ") from class: " + e.getMessage()); + } catch (InstantiationException e) { + // should never occur + throw new DavException(DavServletResponse.SC_INTERNAL_SERVER_ERROR, "Failed to create new report (" + reportClass.getName() + ") from class: " + e.getMessage()); } }