jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ang...@apache.org
Subject svn commit: r432273 - /jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/SessionImpl.java
Date Thu, 17 Aug 2006 16:11:37 GMT
Author: angela
Date: Thu Aug 17 09:11:37 2006
New Revision: 432273

URL: http://svn.apache.org/viewvc?rev=432273&view=rev
Log:
work in progress

- javadoc
- remove DIFF comments

Modified:
    jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/SessionImpl.java

Modified: jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/SessionImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/SessionImpl.java?rev=432273&r1=432272&r2=432273&view=diff
==============================================================================
--- jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/SessionImpl.java
(original)
+++ jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/SessionImpl.java
Thu Aug 17 09:11:37 2006
@@ -105,8 +105,6 @@
 
     private static Logger log = LoggerFactory.getLogger(SessionImpl.class);
 
-    // DIFF JR: moved access-right constants to AcessManager
-
     private boolean alive;
 
     /**
@@ -392,14 +390,12 @@
         // build the array of actions to be checked
         String[] actionsArr = actions.split(",");
 
-        // DIFF JR: different AccessManager (delegating to RS). No translation of actions
to READ, WRITE, REMOVE.
         Path targetPath = getQPath(absPath);
         boolean isGranted;
         if (itemExists(absPath)) {
             ItemState itemState = getHierarchyManager().getItemState(targetPath);
             isGranted = getAccessManager().isGranted(itemState, actionsArr);
         } else {
-            // TODO: if spi-ids are used, its possible to build an id for a non-existing
item (see also Node.restore)
             // The given abs-path may point to a non-existing item
             Path parentPath = targetPath;
             NodeState parentState = null;
@@ -433,12 +429,12 @@
         checkIsAlive();
 
         Path parentPath = getQPath(parentAbsPath);
-        // DIFF JR: check for writable parent is performed within importer
+        // NOTE: check if path corresponds to Node and is writable is performed
+        // within the SessionImporter.
         Importer importer = new SessionImporter(parentPath, this, itemStateManager, uuidBehavior);
         return new ImportHandler(importer, getNamespaceResolver(), workspace.getNamespaceRegistry());
     }
 
-    // DIFF JR: dont cast getImportContentHandler to 'ImportHandler' check for instanceof
ErrorHandler
     /**
      * @see javax.jcr.Session#importXML(String, java.io.InputStream, int)
      */



Mime
View raw message