jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mreut...@apache.org
Subject svn commit: r430025 - in /jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/state: TransientChangeLog.java TransientItemStateManager.java
Date Wed, 09 Aug 2006 10:31:17 GMT
Author: mreutegg
Date: Wed Aug  9 03:31:16 2006
New Revision: 430025

URL: http://svn.apache.org/viewvc?rev=430025&view=rev
Log:
Remove unused methods

Modified:
    jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/state/TransientChangeLog.java
    jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/state/TransientItemStateManager.java

Modified: jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/state/TransientChangeLog.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/state/TransientChangeLog.java?rev=430025&r1=430024&r2=430025&view=diff
==============================================================================
--- jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/state/TransientChangeLog.java
(original)
+++ jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/state/TransientChangeLog.java
Wed Aug  9 03:31:16 2006
@@ -247,30 +247,6 @@
     }
 
     /**
-     * TODO: remove this method
-     * @inheritDoc
-     */
-    public NodeState createNodeState(NodeState overlayedState) {
-        ItemId id = overlayedState.getNodeId();
-
-        // check map; synchronized to ensure an entry is not created twice.
-        synchronized (addedStates) {
-            NodeState state;
-//            if ((state = (NodeState) addedStates.get(id)) != null
-//                    || (state = (NodeState) modifiedStates.get(id)) != null) {
-//                String msg = "there's already a node state instance with id " + id;
-//                log.warn(msg);
-//                return state;
-//            }
-
-            state = new NodeState(overlayedState, null, ItemState.STATUS_EXISTING_MODIFIED,
true, this);
-            // put transient state in the map
-            modifiedStates.add(state);
-            return state;
-        }
-    }
-
-    /**
      * @inheritDoc
      * @see TransientItemStateManager#createPropertyState(NodeState, QName)
      */
@@ -281,31 +257,6 @@
         addedStates.add(propState);
         propState.addListener(this);
         return propState;
-    }
-
-    /**
-     * TODO: remove this method
-     * @inheritDoc
-     */
-    public PropertyState createPropertyState(PropertyState overlayedState) {
-
-        PropertyId id = overlayedState.getPropertyId();
-
-        // check map; synchronized to ensure an entry is not created twice.
-        synchronized (addedStates) {
-            PropertyState state;
-//            if ((state = (PropertyState) addedStates.get(id)) != null
-//                    || (state = (PropertyState) modifiedStates.get(id)) != null) {
-//                String msg = "there's already a property state instance with id " + id;
-//                log.warn(msg);
-//                return state;
-//            }
-
-            state = new PropertyState(overlayedState, null, ItemState.STATUS_EXISTING_MODIFIED,
true);
-            // put transient state in the map
-            modifiedStates.add(state);
-            return state;
-        }
     }
 
     /**

Modified: jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/state/TransientItemStateManager.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/state/TransientItemStateManager.java?rev=430025&r1=430024&r2=430025&view=diff
==============================================================================
--- jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/state/TransientItemStateManager.java
(original)
+++ jackrabbit/trunk/contrib/spi/jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/state/TransientItemStateManager.java
Wed Aug  9 03:31:16 2006
@@ -17,7 +17,6 @@
 package org.apache.jackrabbit.jcr2spi.state;
 
 import org.apache.jackrabbit.jcr2spi.operation.Operation;
-import org.apache.jackrabbit.spi.NodeId;
 import org.apache.jackrabbit.name.QName;
 
 import javax.jcr.ItemExistsException;
@@ -78,13 +77,6 @@
                               NodeState parent);
 
     /**
-     * DIFF JACKRABBIT: does not throw ItemStateException
-     * @param overlayedState
-     * @return
-     */
-    NodeState createNodeState(NodeState overlayedState);
-
-    /**
      * Creates a new transient property state for a given <code>parent</code>
      * node state.
      *
@@ -96,13 +88,6 @@
      */
     PropertyState createPropertyState(NodeState parent, QName propName)
             throws ItemExistsException;
-
-    /**
-     * DIFF JACKRABBIT: does not throw ItemStateException
-     * @param overlayedState
-     * @return
-     */
-    PropertyState createPropertyState(PropertyState overlayedState);
 
     /**
      * Disposes the specified instance, i.e. discards it and removes it from



Mime
View raw message