jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mreut...@apache.org
Subject svn commit: r374697 - /incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/value/ValueHelper.java
Date Fri, 03 Feb 2006 15:55:53 GMT
Author: mreutegg
Date: Fri Feb  3 07:55:50 2006
New Revision: 374697

URL: http://svn.apache.org/viewcvs?rev=374697&view=rev
Log:
- Name and Path values are checked twice. e.g. PathValue.valueOf(Path) also checks format.
- removed unused import statements

Modified:
    incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/value/ValueHelper.java

Modified: incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/value/ValueHelper.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/value/ValueHelper.java?rev=374697&r1=374696&r2=374697&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/value/ValueHelper.java
(original)
+++ incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/value/ValueHelper.java
Fri Feb  3 07:55:50 2006
@@ -16,10 +16,6 @@
  */
 package org.apache.jackrabbit.value;
 
-import org.apache.jackrabbit.name.IllegalNameException;
-import org.apache.jackrabbit.name.MalformedPathException;
-import org.apache.jackrabbit.name.Path;
-import org.apache.jackrabbit.name.QName;
 import org.apache.jackrabbit.util.Base64;
 import org.apache.jackrabbit.util.Text;
 import org.apache.jackrabbit.util.TransientFileFactory;
@@ -231,13 +227,6 @@
                             throw new ValueFormatException("failed to convert source value
to PATH value",
                                     re);
                         }
-                        try {
-                            // check path format
-                            Path.checkFormat(path);
-                        } catch (MalformedPathException mpe) {
-                            throw new ValueFormatException("source value " + path
-                                    + " does not represent a valid path", mpe);
-                        }
                         val = PathValue.valueOf(path);
                         break;
 
@@ -275,14 +264,6 @@
                             // should never happen
                             throw new ValueFormatException("failed to convert source value
to NAME value",
                                     re);
-                        }
-                        try {
-                            // check name format
-                            QName.checkFormat(name);
-                        } catch (IllegalNameException ine) {
-                            throw new ValueFormatException("source value "
-                                    + name
-                                    + " does not represent a valid name", ine);
                         }
                         val = NameValue.valueOf(name);
                         break;



Mime
View raw message