jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fmesc...@apache.org
Subject svn commit: r358321 - in /incubator/jackrabbit/trunk/contrib/classloader/src: main/java/org/apache/jackrabbit/classloader/ test/java/org/apache/jackrabbit/classloader/
Date Wed, 21 Dec 2005 16:48:15 GMT
Author: fmeschbe
Date: Wed Dec 21 08:48:06 2005
New Revision: 358321

URL: http://svn.apache.org/viewcvs?rev=358321&view=rev
Log:
- Fix method documentation
- Rename inappropriately named test class

Added:
    incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/ClassLoaderTestBase.java
      - copied, changed from r358296, incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/AbstractClassLoaderTest.java
Removed:
    incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/AbstractClassLoaderTest.java
Modified:
    incubator/jackrabbit/trunk/contrib/classloader/src/main/java/org/apache/jackrabbit/classloader/ExpandingArchiveClassPathEntry.java
    incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/DynamicRepositoryClassLoaderTest.java
    incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/ExpandingArchiveClassPathEntryTest.java
    incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/PatternPathTest.java
    incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/TestAll.java

Modified: incubator/jackrabbit/trunk/contrib/classloader/src/main/java/org/apache/jackrabbit/classloader/ExpandingArchiveClassPathEntry.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/contrib/classloader/src/main/java/org/apache/jackrabbit/classloader/ExpandingArchiveClassPathEntry.java?rev=358321&r1=358320&r2=358321&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/contrib/classloader/src/main/java/org/apache/jackrabbit/classloader/ExpandingArchiveClassPathEntry.java
(original)
+++ incubator/jackrabbit/trunk/contrib/classloader/src/main/java/org/apache/jackrabbit/classloader/ExpandingArchiveClassPathEntry.java
Wed Dec 21 08:48:06 2005
@@ -407,20 +407,17 @@
      * entries in the workspace (and repository) to which the <code>session</code>
      * provides access.
      * <p>
-     * This method works as follows:
-     * <ol>
-     * <li>If the node type <code>rep:jarFile</code> is defined in the
session's
-     *      repository, <code>true</code> is immediately returned.
-     * <li>If an error checking for the node type, <code>false</code> is
-     *      immediately returned.
-     * <li>Next would be to try to define the node type, this requires the
-     *      <code>session</code> to be an instance of <code>CRXSession</code>,
-     *      which is required to access the node type registry. If the session
-     *      is not a <code>CRXSession</code>, <code>false</code>
is returned.
-     * <li>Finally the node type is defined and <code>true</code> is returned.
-     *      If an error occurrs defining the node type, <code>false</code> is
-     *      returned.
-     * </ol>
+     * This method works as follows. If the node type <code>rep:jarFile</code>
+     * is defined in the session's repository, <code>true</code> is immediately
+     * returned. If an error checking for the node type, <code>false</code> is
+     * immediately returned.
+     * <p>
+     * If the node type is not defined, the
+     * {@link NodeTypeSupport#registerNodeType(Workspace)} method is called
+     * to register the node type. Any errors occurring while calling or
+     * executing this method is logged an <code>false</code> is returned.
+     * Otherwise, if node type registration succeeded, <code>true</code> is
+     * returned.
      * <p>
      * This method is synchronized such that two paralell threads do not try
      * to create the node, which might yield wrong negatives.

Copied: incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/ClassLoaderTestBase.java
(from r358296, incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/AbstractClassLoaderTest.java)
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/ClassLoaderTestBase.java?p2=incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/ClassLoaderTestBase.java&p1=incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/AbstractClassLoaderTest.java&r1=358296&r2=358321&rev=358321&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/AbstractClassLoaderTest.java
(original)
+++ incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/ClassLoaderTestBase.java
Wed Dec 21 08:48:06 2005
@@ -57,12 +57,12 @@
 import com.sun.org.omg.CORBA.ExcDescriptionSeqHelper;
 
 /**
- * The <code>AbstractClassLoaderTest</code> TODO
+ * The <code>ClassLoaderTestBase</code> TODO
  *
  * @author fmeschbe
- * @version $Rev:$, $Date:$
+ * @version $Rev:$, $Date$
  */
-public class AbstractClassLoaderTest extends TestCase {
+public class ClassLoaderTestBase extends TestCase {
 
     /** Logger for test cases */
     protected static final Log log =
@@ -79,11 +79,11 @@
 
     private Set createdItems = new HashSet();
 
-    public AbstractClassLoaderTest() {
+    public ClassLoaderTestBase() {
         super();
     }
 
-    public AbstractClassLoaderTest(String name) {
+    public ClassLoaderTestBase(String name) {
         super(name);
     }
 

Modified: incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/DynamicRepositoryClassLoaderTest.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/DynamicRepositoryClassLoaderTest.java?rev=358321&r1=358320&r2=358321&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/DynamicRepositoryClassLoaderTest.java
(original)
+++ incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/DynamicRepositoryClassLoaderTest.java
Wed Dec 21 08:48:06 2005
@@ -30,7 +30,7 @@
  *
  * @author Felix Meschberger
  */
-public class DynamicRepositoryClassLoaderTest extends AbstractClassLoaderTest {
+public class DynamicRepositoryClassLoaderTest extends ClassLoaderTestBase {
 
     private static final String CLASSES_FOLDER = "/node1/classes";
     private static final String JAR_FILE = "/node1/mock.jar";

Modified: incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/ExpandingArchiveClassPathEntryTest.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/ExpandingArchiveClassPathEntryTest.java?rev=358321&r1=358320&r2=358321&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/ExpandingArchiveClassPathEntryTest.java
(original)
+++ incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/ExpandingArchiveClassPathEntryTest.java
Wed Dec 21 08:48:06 2005
@@ -27,7 +27,7 @@
 
 import org.apache.jackrabbit.util.Text;
 
-public class ExpandingArchiveClassPathEntryTest extends AbstractClassLoaderTest {
+public class ExpandingArchiveClassPathEntryTest extends ClassLoaderTestBase {
 
     private static final String NODE_TYPE = "rep:jarFile";
 

Modified: incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/PatternPathTest.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/PatternPathTest.java?rev=358321&r1=358320&r2=358321&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/PatternPathTest.java
(original)
+++ incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/PatternPathTest.java
Wed Dec 21 08:48:06 2005
@@ -37,7 +37,7 @@
  *
  * @author Felix Meschberger
  */
-public class PatternPathTest extends AbstractClassLoaderTest {
+public class PatternPathTest extends ClassLoaderTestBase {
 
     private static final String DUMMY = "/dummy/classes";
     private static final String[] patterns = {

Modified: incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/TestAll.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/TestAll.java?rev=358321&r1=358320&r2=358321&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/TestAll.java
(original)
+++ incubator/jackrabbit/trunk/contrib/classloader/src/test/java/org/apache/jackrabbit/classloader/TestAll.java
Wed Dec 21 08:48:06 2005
@@ -24,11 +24,11 @@
     public static Test suite() {
         TestSuite suite = new TestSuite("Test for Jackrabbit Class Loader");
         //$JUnit-BEGIN$
-        suite.addTest(new AbstractClassLoaderTest("repositoryStart"));
+        suite.addTest(new ClassLoaderTestBase("repositoryStart"));
         suite.addTestSuite(PatternPathTest.class);
         suite.addTestSuite(ExpandingArchiveClassPathEntryTest.class);
         suite.addTestSuite(DynamicRepositoryClassLoaderTest.class);
-        suite.addTest(new AbstractClassLoaderTest("repositoryStop"));
+        suite.addTest(new ClassLoaderTestBase("repositoryStop"));
         //$JUnit-END$
         return suite;
     }



Mime
View raw message