jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mreut...@apache.org
Subject svn commit: r290649 - /incubator/jackrabbit/trunk/src/test/org/apache/jackrabbit/test/api/PropertyReadMethodsTest.java
Date Wed, 21 Sep 2005 08:22:24 GMT
Author: mreutegg
Date: Wed Sep 21 01:22:18 2005
New Revision: 290649

URL: http://svn.apache.org/viewcvs?rev=290649&view=rev
Log:
JCR-156: Review test cases and cross check with 1.0 specification
- PropertyReadMethodsTest.testGetValueCopyStoredValues() is level 1 test but uses Session.getValueFactory()
which is only required in level 2.

Modified:
    incubator/jackrabbit/trunk/src/test/org/apache/jackrabbit/test/api/PropertyReadMethodsTest.java

Modified: incubator/jackrabbit/trunk/src/test/org/apache/jackrabbit/test/api/PropertyReadMethodsTest.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/src/test/org/apache/jackrabbit/test/api/PropertyReadMethodsTest.java?rev=290649&r1=290648&r2=290649&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/src/test/org/apache/jackrabbit/test/api/PropertyReadMethodsTest.java
(original)
+++ incubator/jackrabbit/trunk/src/test/org/apache/jackrabbit/test/api/PropertyReadMethodsTest.java
Wed Sep 21 01:22:18 2005
@@ -295,15 +295,13 @@
         if (values.length == 0) {
             throw new NotExecutableException("No testable propery found.");
         }
-        values[0] = session.getValueFactory().createValue(values[0].getString() + "abc");
+        values[0] = null;
 
-        // re-acquire the values and compare the zeroth values
+        // re-acquire the values and check if nulled value still exists
         Value[] values2 = prop.getValues();
-        String s1 = values[0].getString();
-        String s2 = values2[0].getString();
-        assertFalse("Changes on the array returned by Property.getNodes() must " +
+        assertNotNull("Changes on the array returned by Property.getValues() must " +
                 "not be reflected in the internal storage.",
-                s1.equals(s2));
+                values2[0]);
     }
 
     /**



Mime
View raw message