jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ste...@apache.org
Subject svn commit: r190604 - in /incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core: ItemManager.java NodeImpl.java
Date Tue, 14 Jun 2005 14:55:40 GMT
Author: stefan
Date: Tue Jun 14 07:55:40 2005
New Revision: 190604

URL: http://svn.apache.org/viewcvs?rev=190604&view=rev
Log:
some inline comments

Modified:
    incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/ItemManager.java
    incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java

Modified: incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/ItemManager.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/ItemManager.java?rev=190604&r1=190603&r2=190604&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/ItemManager.java (original)
+++ incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/ItemManager.java Tue Jun
14 07:55:40 2005
@@ -175,7 +175,12 @@
         NodeDefId defId = state.getDefinitionId();
         NodeDefinitionImpl def = session.getNodeTypeManager().getNodeDefinition(defId);
         if (def == null) {
-            log.warn("node at " + safeGetJCRPath(state.getId()) + " has invalid definitionId
(" + defId + ")");
+            /**
+             * todo need proper way of handling inconsistent/corrupt definition
+             * e.g. 'flag' items that refer to non-existent definitions
+             */
+            log.warn("node at " + safeGetJCRPath(state.getId())
+                    + " has invalid definitionId (" + defId + ")");
 
             // fallback: try finding applicable definition
             NodeId parentId = new NodeId(state.getParentUUID());
@@ -193,7 +198,12 @@
         PropDefId defId = state.getDefinitionId();
         PropertyDefinitionImpl def = session.getNodeTypeManager().getPropertyDefinition(defId);
         if (def == null) {
-            log.warn("property at " + safeGetJCRPath(state.getId()) + " has invalid definitionId
(" + defId + ")");
+            /**
+             * todo need proper way of handling inconsistent/corrupt definition
+             * e.g. 'flag' items that refer to non-existent definitions
+             */
+            log.warn("property at " + safeGetJCRPath(state.getId())
+                    + " has invalid definitionId (" + defId + ")");
 
             // fallback: try finding applicable definition
             NodeId parentId = new NodeId(state.getParentUUID());

Modified: incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java?rev=190604&r1=190603&r2=190604&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java (original)
+++ incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java Tue Jun 14
07:55:40 2005
@@ -123,7 +123,12 @@
         try {
             nt = session.getNodeTypeManager().getNodeType(state.getNodeTypeName());
         } catch (NoSuchNodeTypeException e) {
-            log.warn("Fallback to nt:unstructured for unknown node type '" + state.getNodeTypeName()
+ "' of node " +safeGetJCRPath());
+            /**
+             * todo need proper way of handling inconsistent/corrupt node type references
+             * e.g. 'flag' nodes that refer to non-registered node types
+             */
+            log.warn("Fallback to nt:unstructured due to unknown node type '"
+                    + state.getNodeTypeName() + "' of node " + safeGetJCRPath());
             nt = session.getNodeTypeManager().getNodeType(NT_UNSTRUCTURED);
         }
         this.nodeType = nt;



Mime
View raw message