jackrabbit-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ju...@apache.org
Subject svn commit: r169250 - in /incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype: ItemDefinitionState.java NodeDefinitionState.java PropertyDefinitionState.java package.html
Date Mon, 09 May 2005 08:05:32 GMT
Author: jukka
Date: Mon May  9 01:05:32 2005
New Revision: 169250

URL: http://svn.apache.org/viewcvs?rev=169250&view=rev
Log:
JCR-EXT: Minor updates to node type state code.
	* package.html: Added a note about state equality
	* ItemDefinitionState.java: Protected the constructor
	* NodeDefinitionState.java: Renamed the AllowsSameNameSiblings getter.
	* plus minor cleanups

Modified:
    incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/ItemDefinitionState.java
    incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/NodeDefinitionState.java
    incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/PropertyDefinitionState.java
    incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/package.html

Modified: incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/ItemDefinitionState.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/ItemDefinitionState.java?rev=169250&r1=169249&r2=169250&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/ItemDefinitionState.java
(original)
+++ incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/ItemDefinitionState.java
Mon May  9 01:05:32 2005
@@ -41,7 +41,10 @@
     /** The Protected item definition property. */
     private boolean isProtected; // avoid the reserved word "protected"
 
-    /** Creates an empty item definition state instance. */
+    /**
+     * Creates an empty item definition state instance. This constructor
+     * is protected because this class must only be used through subclasses.
+     */
     protected ItemDefinitionState() {
         name = null;
         autoCreated = false;

Modified: incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/NodeDefinitionState.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/NodeDefinitionState.java?rev=169250&r1=169249&r2=169250&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/NodeDefinitionState.java
(original)
+++ incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/NodeDefinitionState.java
Mon May  9 01:05:32 2005
@@ -86,7 +86,7 @@
      *
      * @return AllowsSameNameSiblings property value
      */
-    public boolean isAllowsSameNameSiblings() {
+    public boolean allowsSameNameSiblings() {
         return allowsSameNameSiblings;
     }
 

Modified: incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/PropertyDefinitionState.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/PropertyDefinitionState.java?rev=169250&r1=169249&r2=169250&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/PropertyDefinitionState.java
(original)
+++ incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/PropertyDefinitionState.java
Mon May  9 01:05:32 2005
@@ -38,6 +38,7 @@
 
     /** Creates an empty property definition state instance. */
     public PropertyDefinitionState() {
+        super();
         requiredType = PropertyType.UNDEFINED;
         valueConstraints = new Vector();
         multiple = false;

Modified: incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/package.html
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/package.html?rev=169250&r1=169249&r2=169250&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/package.html
(original)
+++ incubator/jackrabbit/trunk/contrib/jcr-ext/src/java/org/apache/jackrabbit/state/nodetype/package.html
Mon May  9 01:05:32 2005
@@ -8,4 +8,16 @@
 org.apache.jackrabbit.session.nodetype} package implements the standard
 {@link javax.jcr.nodetype JCR node type interfaces} based on underlying
 node type state managed by classes from this package.
+</p>
+
+<h2>Implementation notes</h2>
+<h3>State equality</h3>
+<p>
+Although in most use cases the node type state instances do not change
+once they have been created and properly configured, but they still are
+mutable and it is possible for their state to change. Thus none of these
+classes override the default {@link Object#equals(Object) equals()} and
+{@link Object#hashCode() hashCode()} methods that are based on reference
+equality.
+</p>
 </body>



Mime
View raw message