Return-Path: Delivered-To: apmail-incubator-jackrabbit-commits-archive@www.apache.org Received: (qmail 9198 invoked from network); 17 Mar 2005 18:16:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 17 Mar 2005 18:16:53 -0000 Received: (qmail 32631 invoked by uid 500); 17 Mar 2005 18:16:52 -0000 Mailing-List: contact jackrabbit-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jackrabbit-dev@incubator.apache.org Delivered-To: mailing list jackrabbit-commits@incubator.apache.org Received: (qmail 32617 invoked by uid 500); 17 Mar 2005 18:16:52 -0000 Delivered-To: apmail-incubator-jackrabbit-cvs@incubator.apache.org Received: (qmail 32613 invoked by uid 99); 17 Mar 2005 18:16:52 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from minotaur.apache.org (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.28) with SMTP; Thu, 17 Mar 2005 10:16:52 -0800 Received: (qmail 9181 invoked by uid 65534); 17 Mar 2005 18:16:51 -0000 Message-ID: <20050317181651.9180.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: svnmailer-1.0.0-dev Date: Thu, 17 Mar 2005 18:16:51 -0000 Subject: svn commit: r157956 - incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/SessionImpl.java To: jackrabbit-cvs@incubator.apache.org From: mreutegg@apache.org X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Author: mreutegg Date: Thu Mar 17 10:16:49 2005 New Revision: 157956 URL: http://svn.apache.org/viewcvs?view=3Drev&rev=3D157956 Log: Session.checkPermission() logs a warn message with full stacktrace if an ac= tion is denied. Permission checks are daily business and should not log suc= h stacktraces. Modified: incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/SessionI= mpl.java Modified: incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/Se= ssionImpl.java URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/src/java/org/= apache/jackrabbit/core/SessionImpl.java?view=3Ddiff&r1=3D157955&r2=3D157956 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D --- incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/SessionI= mpl.java (original) +++ incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/SessionI= mpl.java Thu Mar 17 10:16:49 2005 @@ -561,6 +561,10 @@ String msg =3D "invalid path: " + absPath; log.warn(msg, mpe); throw new AccessControlException(ADD_NODE_ACTION); + } catch (AccessDeniedException re) { + // otherwise the RepositoryException catch clause will + // log a warn message, which is not appropriate in this ca= se. + throw new AccessControlException(ADD_NODE_ACTION); } catch (RepositoryException re) { String msg =3D "failed to check WRITE permission on parent= of " + absPath; log.warn(msg, re); @@ -588,6 +592,10 @@ String msg =3D "invalid path: " + absPath; log.warn(msg, mpe); throw new AccessControlException(REMOVE_ACTION); + } catch (AccessDeniedException re) { + // otherwise the RepositoryException catch clause will + // log a warn message, which is not appropriate in this ca= se. + throw new AccessControlException(REMOVE_ACTION); } catch (RepositoryException re) { String msg =3D "failed to check REMOVE permission on " + a= bsPath; log.warn(msg, re); @@ -630,6 +638,10 @@ } catch (MalformedPathException mpe) { String msg =3D "invalid path: " + absPath; log.warn(msg, mpe); + throw new AccessControlException(SET_PROPERTY_ACTION); + } catch (AccessDeniedException re) { + // otherwise the RepositoryException catch clause will + // log a warn message, which is not appropriate in this ca= se. throw new AccessControlException(SET_PROPERTY_ACTION); } catch (RepositoryException re) { String msg =3D "failed to check WRITE permission on parent= of " + absPath;