Mailing-List: contact users-help@isis.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@isis.apache.org
MIME-Version: 1.0
In-Reply-To: <55D59251.5070709@gesconsultor.com>
References: <55D59251.5070709@gesconsultor.com>
Date: Thu, 20 Aug 2015 10:15:29 +0100
Message-ID: 
 <CALJOYLEquFT0BMjYyLSCX6GGrE-v681mG7SFX0R7bf5muSiWjA@mail.gmail.com>
Subject: Re: ISIS-1044 issue with Collections
From: Dan Haywood <dan@haywood-associates.co.uk>
To: users <users@isis.apache.org>
Content-Type: multipart/alternative; boundary=001a113de654b47181051dba97a4

--001a113de654b47181051dba97a4
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Nacho,

Thanks for checking this out, and you are right, of course... the code
should take the return type of the getter into account.

I'll tidy up your code by way of a fix.

Thanks again,
Dan
On 20 Aug 2015 09:40, "Nacho C=C3=A1novas Rej=C3=B3n" <n.canovas@gesconsult=
or.com>
wrote:

> Hi Dan.
>
> In order to test new changes on 1.9.0 release, I think I find some bug.
>
> My problem is in "*ISIS-1044: fixing by filtering the
> PropertyAccessorFacet and CollectionAccessorFacet, also the
> ActionInvocationFacet (for contributed collections/properties):*" issue.
>
> You modified "*getProperty*" method on class
> "*CollectionAccessorFacetViaAccessor*". I show you the code:
>
> *OLD Code*
>
> final Object collectionOrArray =3D ObjectAdapter.InvokeUtils.invoke(metho=
d,
> owningAdapter);
>
> *NEW Code*
>
> final Object collectionOrArray =3D ObjectAdapter.InvokeUtils.invoke(metho=
d,
> owningAdapter);
>
> final ObjectAdapter collectionAdapter =3D
> getAdapterManager().adapterFor(collectionOrArray);
>
> final FacetedMethod facetedMethod =3D (FacetedMethod) getFacetHolder();
> final Class<?> collectionElementType =3D facetedMethod.getType();
>
> final List<ObjectAdapter> visibleAdapters =3D
>         ObjectAdapter.Util.visibleAdapters(
>                 collectionAdapter,
>                 authenticationSession, deploymentCategory);
> final List<Object> visibleObjects =3D Lists.newArrayList(
>         Iterables.transform(visibleAdapters,
> ObjectAdapter.Functions.getObject()));
>
> return visibleObjects;
>
> Now I explain my problem.
>
> I have for example  this property defined in one of my entities.
>
> private SortedSet<Product> customSelectedProducts =3D new TreeSet<Product=
>();
>
> public SortedSet<Product> getCustomSelectedProducts() {
>     return this.customSelectedProducts;
> }
>
> public void setCustomSelectedProducts(
>         final SortedSet<Product> customSelectedProducts) {
>     this.customSelectedProducts =3D customSelectedProducts;
> }
>
> And when I try to get his value, I received:
>
> java.lang.ClassCastException: java.util.ArrayList cannot be cast to
> java.util.SortedSet
>
> You will see that you return always an ArrayList when it's a Collection,
> but maybe there is other kind of collections (SortedSet in my case) and i=
t
> will failed on get method.
>
> I did some dirty and not to well modification for performance to work wit=
h
> it in order to advance changing next code:
>
> final List<Object> visibleObjects =3D Lists.newArrayList(
>         Iterables.transform(visibleAdapters,
> ObjectAdapter.Functions.getObject()));
>
> return visibleObjects;
> *
> **to*
>
> ((Collection) collectionOrArray).clear();
> ((Collection) collectionOrArray).addAll(Lists.newArrayList(
>         Iterables.transform(visibleAdapters,
> ObjectAdapter.Functions.getObject())));
>
> return collectionOrArray;
>
> I have the same problem in method "*invoke*" from class
> "*ActionInvocationFacetForDomainEventAbstract*" and I fixed it with a
> similar way than last mail:
>
> final List<Object> visibleObjects =3D
>         Lists.newArrayList(Lists.transform(
>                 visibleAdapters, ObjectAdapter.Functions.getObject()));
> final ObjectAdapter visibleObjectsAsAdapter =3D
> getAdapterManager().adapterFor(visibleObjects);
>
> *to*
>
> ((Collection<Object>) result).clear();
> ((Collection<Object>)
> result).addAll(Lists.newArrayList(Lists.transform(visibleAdapters,
> ObjectAdapter.Functions.getObject())));
>
> final ObjectAdapter visibleObjectsAsAdapter =3D
> this.getAdapterManager().adapterFor(result);
>
> I hope you're well.
>
> Best regards and thanks.
>
> --
> Ignacio C=C3=A1novas Rej=C3=B3n
> Tel. 902 900 231
> Fax  96 353 19 09
> n.canovas@gesconsultor.com
> www.gesconsultor.com
>
> Este mensaje y los ficheros anexos son confidenciales. Los mismos
> contienen informaci=C3=B3n reservada que no puede ser difundida. Si usted=
 ha
> recibido este correo por error, tenga la amabilidad de eliminarlo de su
> sistema y avisar al remitente mediante reenv=C3=ADo a su direcci=C3=B3n e=
lectr=C3=B3nica;
> no deber=C3=A1 copiar el mensaje ni divulgar su contenido a ninguna perso=
na.
>
> Su direcci=C3=B3n de correo electr=C3=B3nico junto a sus datos personales=
 constan en
> un fichero titularidad de GESDATOS SOFTWARE S.L. cuya finalidad es la de
> mantener el contacto con Ud. Si quiere saber de qu=C3=A9 informaci=C3=B3n=
 disponemos
> de Ud., modificarla, y en su caso, cancelarla, puede hacerlo enviando un
> escrito al efecto, acompa=C3=B1ado de una fotocopia de su D.N.I. a la sig=
uiente
> direcci=C3=B3n: GESDATOS SOFTWARE S.L. Av. Cortes Valencianas 50-1=C2=BA-=
C, C.P.
> 46015 de Valencia. Asimismo, es su responsabilidad comprobar que este
> mensaje o sus archivos adjuntos no contengan virus inform=C3=A1ticos, y e=
n caso
> que los tuvieran eliminarlos.
>
>
>
> ---
> El software de antivirus Avast ha analizado este correo electr=C3=B3nico =
en
> busca de virus.
> http://www.avast.com
>

--001a113de654b47181051dba97a4--