isis-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JohanDoornen...@filternet.nl
Subject Re: render contributed action eagerly
Date Wed, 04 Feb 2015 11:14:59 GMT
Hi Dan,



The problem is still persisting. It is not blocking at all beause I can solve it in several
ways. But just to let you know...

Note: is a contributed collection.

See code: [1] line 69

See online example: [2] (login with frans - pass



grtz Johan



[1] https://github.com/johandoornenbal/matching/blob/master/dom/src/main/java/info/matchingservice/dom/Match/BrancheElementComparisonService.java



[2] http://xtalus.apps.gedge.nl/simple/wicket/entity/info.matchingservice.dom.Profile.ProfileElementTag:L_25


Just got round to looking at this... can't reproduce the problem, I'm
afraid.

Well, I did find a slight issue... the default value for
@CollectionLayout#renderType() was set to EAGERLY, should've been LAZILY.
Fixed that.

Anyway, what you should see is:

- if the xxx.layout.json specifies the renderType, then this will be used
[1]
- otherwise, will use @CollectionLayout#renderType(), if present (and will
default to LAZILY if the renderType attribute is not specified)
- otherwise, if there is no @CollectionLayout, then will look at the
deprecated @Render.  That one defaults to EAGERLY.

Double check with the latest archetype (I just recreated it), see if you
can reproduce with that.  Give the build 30 mins or so from this email to
do its thang.

Thx
Dan





[1]
https://github.com/apache/isis/blob/94529f19bef246cadc667344873b382f16c751e6/example/application/todoapp/dom/src/main/java/dom/todo/ToDoItem.layout.json#L175




On 29 January 2015 at 12:01,  wrote:

> Hi Dan,
>
>
>
> The deprecated works correctly indeed.
>
>
>
> grtz Johan
>
>
>
>
> hmm, that looks correct.
>
> I wonder if there's a bug with that annotation.
>
> If you replace @CollectionLayout(render=...) with the deprecated
> @Render(Type.EAGERLY), does it work?
>
>
>
> On 29 January 2015 at 10:43,  wrote:
>
> > Hi,
> >
> >
> >
> > Is there a way to render the (list) result of a contributed action
> eagerly?
> >
> >
> >
> > I tried:
> >
> >
> >             @Action(semantics=SemanticsOf.SAFE)
> >
> >             @CollectionLayout(render=RenderType.EAGERLY)
> >
> >             public List showProfileMatches(Profile demandProfile) {
> >
> >
> >
> >         [1] line 39
> > grtz Johan
> >
> >
> >
> > [1]
> >
> >
> >
> https://github.com/johandoornenbal/matching/blob/master/dom/src/main/java/info/matchingservice/dom/Match/ProfileMatchingService.java
> >
> >
> >
> >
> >
>
>
>
>

	 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message