iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [iotdb] zyk990424 commented on a change in pull request #3916: [IOTDB-1666] Implement vector support align by device
Date Tue, 14 Sep 2021 02:34:28 GMT

zyk990424 commented on a change in pull request #3916:
URL: https://github.com/apache/iotdb/pull/3916#discussion_r707861044



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##########
@@ -1191,11 +1145,20 @@ public boolean isPathExist(PartialPath path) {
     return mtree.isPathExist(path);
   }
 
+  protected IMeasurementMNode getMeasurementMNode(PartialPath fullPath) throws MetadataException
{
+    return (IMeasurementMNode) getNodeByPath(fullPath);
+  }
+
   /** Get node by path */
   public IMNode getNodeByPath(PartialPath path) throws MetadataException {
     return mtree.getNodeByPath(path);
   }
 
+  public IMeasurementSchema getMeasurementSchemaByPath(PartialPath fullPath)
+      throws MetadataException {
+    return ((MeasurementMNode) IoTDB.metaManager.getNodeByPath(fullPath)).getSchema();
+  }
+

Review comment:
       There's already a equivalent method in MManager, 
   public IMeasurementSchema getSeriesSchema(PartialPath fullPath) throws MetadataException
   You could use this instead without adding new method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message